Make WordPress Core

Opened 18 years ago

Closed 17 years ago

Last modified 17 years ago

#3066 closed defect (bug) (duplicate)

backslash disappears in <pre>

Reported by: bzend's profile bzend Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0.4
Component: General Keywords: pre, code, backslash, escape, unescape
Focuses: Cc:

Description

Posting code on my blog, I realized that
<pre>\n\t\"</pre>
displays as
<pre>nt\"<pre>
(\n and \t are messed up, \" is not). This only occurs with the <pre> tag - <code> and <kbd> work just fine.

I tried to locate the source of the problem, and I tracked it down to wpautop (in functions-formatting.php), where in the end there is a line

$pee = preg_replace('!(<pre.*?>)(.*?)</pre>!ise', " stripslashes('$1') .  stripslashes(clean_pre('$2'))  . '</pre>' ", $pee);

The problem is obviously in stripslashes(clean_pre('$2')).

I did't get into the details, but I don't see why whould <pre> tags need to be cleaned at all: isn't everything between <pre> and </pre> supposed to remain untouched? - in my view, that's the whole point of <pre>!

Change History (6)

#1 @bzend
18 years ago

  • Summary changed from backslash dissapears in <pre> to backslash disappears in <pre>

#2 @darkfate
18 years ago

Yea, I noticed this too. +1 for taking out stripslashes.

#3 @johnbillion
17 years ago

Removing stripslashes won't solve this. When the post is displayed on the blog the speech mark will have an additional backslash in front of it which is added by addslashes before the post is saved to the database. This needs to be removed by stripslashes at some point.

#4 @Nazgul
17 years ago

  • Milestone set to 2.4 (future)

#5 @mdawaffe
17 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #2059.

#6 @foolswisdom
17 years ago

  • Milestone 2.4 (next) deleted
Note: See TracTickets for help on using tickets.