WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#30668 closed defect (bug) (fixed)

DFW: fade in triggered when typing while mouse is outside editor

Reported by: iseulde's profile iseulde Owned by:
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords: has-patch commit
Focuses: javascript Cc:

Description

​https://wordpress.slack.com/archives/feature-focus/p1418251444000002

Attachments (4)

30668.patch​ (1.3 KB) - added by iseulde 10 years ago.
30668.2.patch​ (2.5 KB) - added by iseulde 10 years ago.
30668.3.patch​ (2.8 KB) - added by iseulde 10 years ago.
30668.4.patch​ (2.8 KB) - added by iseulde 10 years ago.

Download all attachments as: .zip

Change History (13)

@iseulde
10 years ago

#1 @iseulde
10 years ago

Above patch only fixes is partially. Working on other patch.

#2 @iseulde
10 years ago

Clarification: If we use clientX/Y the coordinates will be the same when the mousemove event is fired alongside the scroll event for Chrome and Safari. But it still fades in when typing more because editorRect doesn't get updated.

@iseulde
10 years ago

#3 @iseulde
10 years ago

This should fix it. Testing a bit more.

This ticket was mentioned in ​Slack in #feature-focus by janneke. ​View the logs.
10 years ago

@iseulde
10 years ago

#5 @iseulde
10 years ago

  • Keywords has-patch added

#6 @azaozz
10 years ago

  • Keywords commit added

30668.3.patch looks good.

@iseulde
10 years ago

#7 @iseulde
10 years ago

Patch 4 only removes an empty line I accidentally added.

#8 @markjaquith
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [30817]:

Editor focus: Don't trigger when typing while the mouse is outside the editor.
props avryl.
fixes #30668.

In [30818]:

Editor focus: Don't trigger when typing while the mouse is outside the editor.
Merges [30817] to the 4.1 branch.
props avryl.
fixes #30668.

This ticket was mentioned in ​Slack in #core by azaozz. ​View the logs.
10 years ago

Note: See TracTickets for help on using tickets.