Image toolbar should only show after repositioning

[iseulde]

There's a 100ms delay between repositioning the image toolbar and showing it (or more depending how fast the browser repositions it). That's annoying because you can see the image toolbar pop up on one part of the page and then suddenly move to another. It should first reposition and then show. I'm not sure why there's a 100ms delay there?

[ocean90]

The reason for the delay: ticket:30664:4.

[iseulde]

Thanks for linking that. :) But I don't fully understand why it's needed, as the image position doesn't change. I'm referring to the second timeout. I remember I put the timeout for the nodechange event there, but not for show. We should really make a habit of adding a comment to timeouts. :)

[azaozz]

The delay on show was meant to remove/reduce the "sliding" effect when the toolbar is visible, nodeChange was fired several times, and the first time was with incorrect position at the top/left (and similar edge cases). Not needed any more as there's no positioning animation.

[azaozz]

In 30829:

TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation. Fixes #30670.

[azaozz]

Reopen for 4.1.

[johnbillion]

In 30906:

TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation.

Merges [30829] to the 4.1 branch.

Fixes #30670.