WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30670 closed defect (bug) (fixed)

Image toolbar should only show after repositioning

Reported by: iseulde Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: TinyMCE Keywords: has-patch commit fixed-major
Focuses: javascript Cc:

Description

There's a 100ms delay between repositioning the image toolbar and showing it (or more depending how fast the browser repositions it). That's annoying because you can see the image toolbar pop up on one part of the page and then suddenly move to another. It should first reposition and then show. I'm not sure why there's a 100ms delay there?

Change History (9)

This ticket was mentioned in Slack in #core by janneke. View the logs.


6 years ago

#2 @ocean90
6 years ago

The reason for the delay: ticket:30664:4.

#3 @iseulde
6 years ago

Thanks for linking that. :) But I don't fully understand why it's needed, as the image position doesn't change. I'm referring to the second timeout. I remember I put the timeout for the nodechange event there, but not for show. We should really make a habit of adding a comment to timeouts. :)

#4 @azaozz
6 years ago

The delay on show was meant to remove/reduce the "sliding" effect when the toolbar is visible, nodeChange was fired several times, and the first time was with incorrect position at the top/left (and similar edge cases). Not needed any more as there's no positioning animation.

Last edited 6 years ago by azaozz (previous) (diff)

#5 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 30829:

TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation. Fixes #30670.

#6 @azaozz
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.1.

#7 @ocean90
6 years ago

  • Keywords has-patch added; needs-patch removed

#8 @nacin
6 years ago

  • Keywords commit fixed-major added

#9 @johnbillion
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30906:

TinyMCE: remove reposition delay on showing the image toolbar. Not needed when no animation.

Merges [30829] to the 4.1 branch.

Fixes #30670.

Note: See TracTickets for help on using tickets.