Twenty Fifteen: Problem with fonts turned off

[pavelevap]

I tried to turn off all Twenty Fifteen fonts in localization files and following URL is called:

<link rel="stylesheet" id="twentyfifteen-fonts-css" href="//fonts.googleapis.com/css?family&amp;subset=latin%2Clatin-ext" type="text/css" media="all">

There is also GET error in browser console. We should not call fonts when they are turned off by translators?

[SergeyBiryukov]

Good catch.

[pavelevap]

And related problem: I tried to make a child theme for 2015, but when I dequeued twentyfifteen-fonts, then parent style.css was not loaded in child theme because there is following dependency:

wp_enqueue_style( 'twentyfifteen-style', get_stylesheet_uri(), array( 'twentyfifteen-fonts', 'genericons' ) );

I am not sure if it is a bug (or I am doing it wrong), but it should be possible to remove fonts from child theme?

[pavelevap]

Child theme was broken here: https://core.trac.wordpress.org/changeset/30692

[SergeyBiryukov]

Yes, the 'twentyfifteen-fonts' dependency should probably be removed.

In Twenty Fourteen, we didn't have 'twentyfourteen-lato' as a dependency for the main stylesheet.

[obenland]

Set variable at beginning of function and remove dependency on fonts.

[obenland]

We should probably remove all dependencies for style.css. Twenty Twelve and Thirteen had no dependencies.

Twenty Fourteen has a Genericon dependency, which doesn't seem good to have. If Genericons are unavailable, the theme should still be styled.

[lancewillett]

Removing Genericons dependencies sounds like a new ticket -- keeping this one focused on the fonts issue.

[lancewillett]

In 30832:

Twenty Fifteen: remove fonts as a style dependency.

Props obenland, SergeyBiryukov. Fixes #30678.

[pavelevap]

But problem with Genericons is the same. When removed in child theme, no styles will be applied and it is wrong...

[pavelevap]

It should be also committed into 4.1 branch?

[iamtakashi]

Replying to pavelevap:

But problem with Genericons is the same. When removed in child theme, no styles will be applied and it is wrong...

"Removing Genericons dependencies sounds like a new ticket -- keeping this one focused on the fonts issue."

Look Lance's comment above. Feel free to open a new ticket.

[pavelevap]

For Genericons I will reopen #30532, there is no need for another ticket.

But this ticket was reopened because fix for fonts was committed only to trunk and not to 4.1 branch, even if it is marked for 4.1 milestone.

[johnbillion]

In 30881:

Twenty Fifteen: remove fonts as a style dependency.

Merges [30832] to the 4.1 branch.

Props obenland, SergeyBiryukov.
Fixes #30678.