WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 4 months ago

#30679 new defect (bug)

Clicking "Restore this Revision" publishes immediately

Reported by: paulschreiber Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Revisions Keywords:
Focuses: Cc:
PR Number:

Description

This is the same as #27244, but for non-autosaved posts.

The "Restore This Revision" button on the revisions screen immediately replaces the post with the autosave without making it clear that that is the case.

Desired behaviour:
Clicking Restore This Revision puts this revision into the editor, saving it as draft.

Example:

  1. Create a post with three revisions, and publish it

Revision A
Revision B
Revision C <-- live and published

  1. On the post edit screen, click on revision B.
  2. On the revisions screen, click Restore This Revision.

Revision A
Revision B
Revision C <-- live and published
Revision B' <-- in the editor, saved as a draft

Change History (8)

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Revisions

#2 follow-up: @jlambe
5 years ago

This could be a great feature. I'm having a situation where I need to maintain documentation pages (saved as WordPress pages post type). One revision is published but now we need to update its content with new features for example.

So start typing and adding new lines in the editor of the current published revision. What would be great is a "Save as a revision" kind of button which will save the new changes but without publishing them. Then allow a user to logout and come back anytime edit the revision and when everything seems good, have the choice to publish it.

Like @paulshriber explains, it's not clear what the "Restore this revision" button is doing. As a end-user, I expected it to load its content inside the editor, allow me to edit it and perhaps publish it immediately right after.

Really looking into this feature and I can help too ;)

Was looking at older tickets for this component and it looks like this could be related with this ticket: https://core.trac.wordpress.org/ticket/23314

Last edited 5 years ago by jlambe (previous) (diff)

#3 in reply to: ↑ 2 ; follow-up: @adamsilverstein
5 years ago

Julien,

Thanks for your offer of help!

I agree, this would be a great feature to have. #23314 is very close to this ticket, almost a duplicate? A good fix would solve both cases.

There are actually several related tickets, including #23314 and #20299 - all these tickets would benefit from something missing from core - the revisioning of post meta (see #20564) - without that feature, the data stored for each revision is limited to the primary editor fields (title, content, excerpt, etc.). We got the hooks needed for this feature into 4.1, leveraged by the plugin linked from the ticket.

If the button were to restore the content only to the editor and not publish the restored revision, how would you change the button text to indicate that action? 'Restore revision data to editor' ? (thats a mouthful!)

Replying to jlambe:

This could be a great feature. I'm having a situation where I need to maintain documentation pages (saved as WordPress pages post type). One revision is published but now we need to update its content with new features for example.

So start typing and adding new lines in the editor of the current published revision. What would be great is a "Save as a revision" kind of button which will save the new changes but without publishing them. Then allow a user to logout and come back anytime edit the revision and when everything seems good, have the choice to publish it.

Like @paulshriber explains, it's not clear what the "Restore this revision" button is doing. As a end-user, I expected it to load its content inside the editor, allow me to edit it and perhaps publish it immediately right after.

Really looking into this feature and I can help too ;)

Was looking at older tickets for this component and it looks like this could be related with this ticket: https://core.trac.wordpress.org/ticket/23314

#4 in reply to: ↑ 3 ; follow-up: @adamsilverstein
5 years ago

Maybe an 'Edit this Revision' button next to 'Restore this Revision'?

Replying to adamsilverstein:

Julien,

Thanks for your offer of help!

I agree, this would be a great feature to have. #23314 is very close to this ticket, almost a duplicate? A good fix would solve both cases.

There are actually several related tickets, including #23314 and #20299 - all these tickets would benefit from something missing from core - the revisioning of post meta (see #20564) - without that feature, the data stored for each revision is limited to the primary editor fields (title, content, excerpt, etc.). We got the hooks needed for this feature into 4.1, leveraged by the plugin linked from the ticket.

If the button were to restore the content only to the editor and not publish the restored revision, how would you change the button text to indicate that action? 'Restore revision data to editor' ? (thats a mouthful!)

Replying to jlambe:

This could be a great feature. I'm having a situation where I need to maintain documentation pages (saved as WordPress pages post type). One revision is published but now we need to update its content with new features for example.

So start typing and adding new lines in the editor of the current published revision. What would be great is a "Save as a revision" kind of button which will save the new changes but without publishing them. Then allow a user to logout and come back anytime edit the revision and when everything seems good, have the choice to publish it.

Like @paulshriber explains, it's not clear what the "Restore this revision" button is doing. As a end-user, I expected it to load its content inside the editor, allow me to edit it and perhaps publish it immediately right after.

Really looking into this feature and I can help too ;)

Was looking at older tickets for this component and it looks like this could be related with this ticket: https://core.trac.wordpress.org/ticket/23314

#5 in reply to: ↑ 4 ; follow-up: @jlambe
5 years ago

'Edit this revision' sounds better and clear. But as how this should be shown visually I do not know. For me, the 'Edit this revision' button should get the style of a primary button and the actual button could align on the left but only simple text (maybe underlined) in order to show it as secondary action.

The fact that 'Edit this revision' becomes visually the primary button gives the user the "safety" of not publishing its revision and allows him to perhaps edit it before publishing. But we don't forget confident users which want to publish immediately the revision by providing the actual button but less present visually.

Not sure if my explanations are clear :)

Replying to adamsilverstein:

Maybe an 'Edit this Revision' button next to 'Restore this Revision'?

Replying to adamsilverstein:

Julien,

Thanks for your offer of help!

I agree, this would be a great feature to have. #23314 is very close to this ticket, almost a duplicate? A good fix would solve both cases.

There are actually several related tickets, including #23314 and #20299 - all these tickets would benefit from something missing from core - the revisioning of post meta (see #20564) - without that feature, the data stored for each revision is limited to the primary editor fields (title, content, excerpt, etc.). We got the hooks needed for this feature into 4.1, leveraged by the plugin linked from the ticket.

If the button were to restore the content only to the editor and not publish the restored revision, how would you change the button text to indicate that action? 'Restore revision data to editor' ? (thats a mouthful!)

Replying to jlambe:

This could be a great feature. I'm having a situation where I need to maintain documentation pages (saved as WordPress pages post type). One revision is published but now we need to update its content with new features for example.

So start typing and adding new lines in the editor of the current published revision. What would be great is a "Save as a revision" kind of button which will save the new changes but without publishing them. Then allow a user to logout and come back anytime edit the revision and when everything seems good, have the choice to publish it.

Like @paulshriber explains, it's not clear what the "Restore this revision" button is doing. As a end-user, I expected it to load its content inside the editor, allow me to edit it and perhaps publish it immediately right after.

Really looking into this feature and I can help too ;)

Was looking at older tickets for this component and it looks like this could be related with this ticket: https://core.trac.wordpress.org/ticket/23314

#6 in reply to: ↑ 5 @adamsilverstein
5 years ago

'Restore this Revision' is actually pretty safe, you can always restore the previous revision to undo the restore action!

I think restoring is the primary action people want to take when visiting the revisions screen (many people head there to undo a published mistake), and the diff view shows the changes, helping the user pick the correct revision to restore (although I'd prefer a preview or customizer integration).

Replying to jlambe:

'Edit this revision' sounds better and clear. But as how this should be shown visually I do not know. For me, the 'Edit this revision' button should get the style of a primary button and the actual button could align on the left but only simple text (maybe underlined) in order to show it as secondary action.

The fact that 'Edit this revision' becomes visually the primary button gives the user the "safety" of not publishing its revision and allows him to perhaps edit it before publishing. But we don't forget confident users which want to publish immediately the revision by providing the actual button but less present visually.

Not sure if my explanations are clear :)

Replying to adamsilverstein:

Maybe an 'Edit this Revision' button next to 'Restore this Revision'?

Replying to adamsilverstein:

Julien,

Thanks for your offer of help!

I agree, this would be a great feature to have. #23314 is very close to this ticket, almost a duplicate? A good fix would solve both cases.

There are actually several related tickets, including #23314 and #20299 - all these tickets would benefit from something missing from core - the revisioning of post meta (see #20564) - without that feature, the data stored for each revision is limited to the primary editor fields (title, content, excerpt, etc.). We got the hooks needed for this feature into 4.1, leveraged by the plugin linked from the ticket.

If the button were to restore the content only to the editor and not publish the restored revision, how would you change the button text to indicate that action? 'Restore revision data to editor' ? (thats a mouthful!)

Replying to jlambe:

This could be a great feature. I'm having a situation where I need to maintain documentation pages (saved as WordPress pages post type). One revision is published but now we need to update its content with new features for example.

So start typing and adding new lines in the editor of the current published revision. What would be great is a "Save as a revision" kind of button which will save the new changes but without publishing them. Then allow a user to logout and come back anytime edit the revision and when everything seems good, have the choice to publish it.

Like @paulshriber explains, it's not clear what the "Restore this revision" button is doing. As a end-user, I expected it to load its content inside the editor, allow me to edit it and perhaps publish it immediately right after.

Really looking into this feature and I can help too ;)

Was looking at older tickets for this component and it looks like this could be related with this ticket: https://core.trac.wordpress.org/ticket/23314

#7 @jlambe
5 years ago

You're right. Whatever the case scenario is (working on incremental changes or restore a previous version), both actions should be available.

Like pointed, this ticket is related to 27244, 23314.

The current "Restore this revision" will update current published post with revision content and redirect to the edit screen with a message "{Post} restored and published".

The "Edit this revision" points to the edit screen with the revision content loaded. The difference here might be how the "publish" metabox will behave: display a "publish" or "update" button ?! Then this becomes related to this ticket I suppose: 23352 and this post: https://make.wordpress.org/core/2013/01/29/editorial-flow-office-hours-today-tuesday-at-1800/ Working on a unified publish/revision metabox ?

This ticket was mentioned in Slack in #core by adamsilverstein. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.