Customizer Background does not restore default image

[dreamwhisper]

Related #21483

In 4.1RC, it appears you are not able to reselect a default image after uploading an alternate image.

//* Add support for custom background
add_theme_support( 'custom-background', array(
        'default-image' => get_stylesheet_directory_uri() . '/images/bg.png',
        'default-color' => 'eee',
) );

Steps to replicate:

• Set a default image in the custom-background function as above
• In the customizer, click Change Image to select a different image
• Click Default Image to restore the original default image

The default image is restored as the thumbnail, but is not displayed as the background on the front end.

In addition, previously, you had the options to:

• Upload an alternate image
• Restore the default image
• Remove the image altogether

All of these options are desirable when specifying a default.

[ocean90]

unfinished

[celloexpressions]

Empty the setting when restoring the default.

[celloexpressions]

My patch may work, but totally untested, and there's a lot of inconsistency across themes here. I had a lot of trouble with this in the original patch, and I probably shouldn't look any more deeply here again.

[ocean90]

30683.2.patch​ should fix the issue. Needs some more testing.

The underlying issue is that the Customizer can't remove a setting like the Custom Header/Background screen does, see trunk/src/wp-admin/custom-background.php@30657#L174​.

[ocean90]

In 30849:

Customizer: Re-add the possibility to remove and restore a default background image.

see #21483.
fixes #30683 for trunk.

[johnbillion]

This is a big improvement over 4.0.

[johnbillion]

In 30911:

Customizer: Re-add the possibility to remove and restore a default background image.

Merges [30849] to the 4.1 branch.

Fixes #30683