WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30692 closed defect (bug) (fixed)

Shaky screens on OS-X

Reported by: Clorith Owned by:
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Administration Keywords:
Focuses: ui, administration Cc:

Description

Due to the what appears to be the OS-X implementation of iOS like features with scrolling past boundaries it seems the admin menu causes screen shaking on pages that involve scrolling.

The issue is restricted to OS-X and does not present it self on Windows

If the cause truly is the boundary overflow scrolling then it might be an issue with generic iOS devices as well like iPads that have a big enough viewport to include the menu by default?

As reported by @sormano in https://wordpress.org/support/topic/shaking-screen

Attachments (1)

30692.patch (2.4 KB) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (11)

#1 @johnbillion
6 years ago

  • Component changed from General to Administration
  • Focuses administration added

Confirmed. Reproducible when the admin menu is taller than the browser window.

@azaozz
6 years ago

#2 @azaozz
6 years ago

  • Milestone changed from Awaiting Review to 4.1

In 30692.patch: fix menu "shakiness" in MacOS/Chrome and Safari when over-scrolling. Needs more testing but seems to work better in Chrome than in Safari (Firefox is not affected).

Would be good to get that in 4.1. Alternatively can disable the menu pinning in Chrome and Safari on MacOS.

Last edited 6 years ago by azaozz (previous) (diff)

#3 @azaozz
6 years ago

In 30844:

Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.
See #30692.

#4 @ocean90
6 years ago

  • Keywords has-patch added

#5 @azaozz
6 years ago

In 30852:

Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.
See #30692.

#6 @nacin
6 years ago

  • Keywords commit fixed-major added

Are these patches good enough for 4.1? Please remove the keywords I'm adding if not.

This ticket was mentioned in Slack in #core by johnbillion. View the logs.


6 years ago

#8 @johnbillion
6 years ago

In 30917:

Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.

Merges [30844] to the 4.1 branch.

See #30692.

#9 @johnbillion
6 years ago

In 30918:

Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.

Merges [30852] to the 4.1 branch.

See #30692.

#10 @johnbillion
6 years ago

  • Keywords has-patch commit fixed-major removed
  • Resolution set to fixed
  • Status changed from new to closed

This looks pretty good now.

Note: See TracTickets for help on using tickets.