Missing localization for image toolbar

[pavelevap]

I am not sure, but localization did not work for me for edit and remove buttons. See attached patch...

We can use existing strings, so no problems for translators. Also there is no need for context, I guess...

[azaozz]

The Remove string is not in there but Edit is just few lines above. It's used in the TinyMCE menubar. To enable it for testing, comment out 'menubar' => false, https://core.trac.wordpress.org/browser/trunk/src/wp-includes/class-wp-editor.php#L653

[azaozz]

In 30835:

TinyMCE: make the tooltip for the remove button in the image toolbar translatable. Props pavelevap, fixes #30694 for trunk.

[azaozz]

Reopen for 4.1.

[pavelevap]

Yes, I know about previous "Edit" string, but this was in different context. For TinyMCE menu it has meaning "noun" in our language. In Image toolbar it has meaning of action (verb). So, I suggested to use other current string "Edit" (without context) which is available. Using the same string for TinyMCE menu and action for editing image is not good...

So we have to rename the whole variable to enable context for this string?

[azaozz]

Replying to pavelevap:

So we have to rename the whole variable to enable context for this string?

Yes. TinyMCE uses simple JS object for translations. The English strings are keys, the translated strings -- values. If there are two identical keys, the second will overwrite the first.

Don't see a straightforward way to fix this. Perhaps we can change the tooltip to "Edit image".

[azaozz]

This will (most likely) be fixed upstream. For now we can use a space to add another Edit string. Spaces are "meaningless" in HTML so this is 100% backwards compatible.

[azaozz]

In 30839:

TinyMCE: add another Edit translatable string for the tooltip of the Edit button on the image toolbar. Props pavelevap, see #30694.

[cais]

With all of the localization strings in this section of the code using PHP comments to define the string more clearly, wouldn't this be an indicator that the _x function should be used instead of the standard __ function?

[pavelevap]

I do not think that context is needed here, because "Edit" is used as simple verb in other cases. And I also did not want to create new string before release...

[SergeyBiryukov]

Replying to cais:

With all of the localization strings in this section of the code using PHP comments to define the string more clearly, wouldn't this be an indicator that the _x function should be used instead of the standard __ function?

_x() is meant to distinguish the same string used in different contexts. It should not be used as a replacement for translator comments or PHP comments.

[cais]

Replying to SergeyBiryukov:

Thanks for the clarification ... that function's use was a little fuzzy to me in this case. My thinking was, if you are adding PHP comments to describe the string to begin with why not add the extra character or two and make it the context parameter.

[nacin]

[30835] and [30839] appear good.

[johnbillion]

In 30861:

TinyMCE: make the tooltip for the remove button in the image toolbar translatable.

Merges [30835] to the 4.1 branch.

Props pavelevap
Fixes #30694

[johnbillion]

In 30862:

TinyMCE: add another Edit translatable string for the tooltip of the Edit button on the image toolbar.

Merges [30839] to the 4.1 branch.

Props pavelevap
Fixes #30694