Failures calling wp.customize.Control.activate() or wp.customize.Control.deactivate()

[westonruter]

The wp.customize.Control class has two methods activate() and deactivate() which are ‘imported’ from wp.customize.Section and wp.customize.Panel. The activate and deactivate methods are just wrappers around the _toggleActive method. This method is defined on wp.customize.Section and wp.customize.Panel but it was not imported into wp.customize.Control as well, so when you attempt to call control.activate() or control.deactivate() you get the infamous Undefined is not a function since control._toggleActive does not exist.

To reproduce the issue, try running this from the console:

wp.customize.control('blogname').deactivate()

The fix is simple:

src/wp-admin/js/customize-controls.js

@@ -913 +913 @@
                  */
                 deactivate: Container.prototype.deactivate,
 
+                /**
+                 * Re-use _toggleActive from Container class.
+                 *
+                 * @access private
+                 */
+                _toggleActive: Container.prototype._toggleActive,
+
                 dropdownInit: function() {
                         var control      = this,
                                 statuses     = this.container.find('.dropdown-status'),

For interim fix if this does not make it into 4.1 is for plugins to do this:

if ( ! wp.customize.Control.prototype._toggleActive ) {
    wp.customize.Control.prototype._toggleActive = wp.customize.Section.prototype._toggleActive;
}

Relates to the Customizer JS APIs added in #28709. Props to celloexpressions for alerting me to the issue.

[westonruter]

Import missing wp.customize.Control.prototype._toggleActive

[ocean90]

30701.diff​ makes sense.

[westonruter]

​https://github.com/xwp/wordpress-develop/pull/58

[westonruter]

In 30701.2.diff​ I added a lot more unit tests to improve coverage on the new models, including these activate()/deactivate() methods.

[ocean90]

In 30871:

Customizer: Import missing wp.customize.Control.prototype._toggleActive.

Check also if completeCallback is set before calling it.

props westonruter.
see #30701.

[ocean90]

Let's move the unit tests to a new ticket for now.

[westonruter]

Replying to ocean90:

Let's move the unit tests to a new ticket for now.

Should not unit test patches be kept on the tickets for the issues they verify?

[johnbillion]

In 30916:

Customizer: Import missing wp.customize.Control.prototype._toggleActive.

Check also if completeCallback is set before calling it.

Merges [30871] to the 4.1 branch.

Props westonruter.
See #30701.

[ocean90]

In 30919:

Customizer: Add more QUnit tests to improve coverage on the new models.

Includes tests for the broken activate()/deactivate() methods, which were fixed in [30871].

props westonruter.
see #30701.

[jorbin]

[30919] added a failing test.

​https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/44355927

[westonruter]

Strange. Travis reports the error:

Error: Syntax error, unrecognized expression: unsupported pseudo: focusable

But this is valid jQuery: ​http://api.jqueryui.com/focusable-selector/

[ocean90]

Replying to westonruter:

But this is valid jQuery: ​http://api.jqueryui.com/focusable-selector/

jQuery UI, which trunk/tests/qunit/index.html​ doesn't enqeue as a dependency yet. Can't really test this, works locally.

[johnbillion]

Closing this as fixed for 4.1 with [30871].

See #30754 for the qunit failure.

[jorbin]

In 30989:

Add jQuery UI Core as a dependency for qUnit tests

[30919] added more qUnit tests for the Customizer. One of the dependencies for these tests is qUnit. Otherwise we end up with an error due to an unsupported pseudo.

​https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/44873635#L425 shows an example of the failing test.

Props ocean90.
see #30701.
Fixes #30754.

[iseulde]

In 32701:

Customizer: hide controls on test page

Introduced in [30919].
See #32577 and #30701.