WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30714 closed defect (bug) (fixed)

DFW v2: sometimes the right sidebar doesn't fade out in IE

Reported by: azaozz Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Happens in all IE versions. Caused by a knows bug where elements with position != static don't inherit opacity from a parent with position: static.

Change History (10)

#1 @azaozz
6 years ago

Generally there are two ways to fix this:

  • Set position: relative on the parent element (.postbox-container).
  • Apply the opacity to the child elements.

It seems better to use the second option as the first interferes a bit with jQuery calculating offset().top and needs adjustments in editor-expand.js.

Last edited 6 years ago by azaozz (previous) (diff)

#2 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 30853:

Editor, new DFW: fix fading out for the right sidebar in IE. Fixes #30714.

#3 @azaozz
6 years ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 4.1.

#4 @iseulde
6 years ago

Maybe only do this for IE? And leave a comment/ticket number there so we know why in the future?

#5 @azaozz
6 years ago

Yeah, was thinking to change the selectors in IE only but that makes it "messier". We will have to set the transition on the parent element (for non-IE), then negate it which is not ideal. Having different selectors in different browsers might bring inconsistencies in the future.

#6 @markjaquith
6 years ago

Is there a downside to leaving the child selectors in for all browsers? It’s not a huge number of child elements...

#7 @azaozz
6 years ago

No downside. By default there is only one child in each .postbox-container. However there are couple of actions that can be used to output other elements, hence the .postbox-container > * selector.

#8 @nacin
6 years ago

  • Keywords has-patch fixed-major added

This ticket was mentioned in ​Slack in #core by nacin. ​View the logs.


6 years ago

#10 @johnbillion
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30942:

Editor, new DFW: fix fading out for the right sidebar in IE.

Merges [30853] to the 4.1 branch.

Fixes #30714.

Note: See TracTickets for help on using tickets.