WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #30724, comment 11


Ignore:
Timestamp:
12/16/2014 04:19:16 PM (6 years ago)
Author:
lancewillett
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30724, comment 11

    initial v1  
    1 Thanks for the clarification, much appreciated.
    2 
    3 Replying to [comment:10 ocean90]:
    4 > Replying to [comment:8 adamsilverstein]:
    5 > > @ocean90: I'm curious about your removal of escaping from translations - can you briefly explain/point me to the the logic?
    6 >
    7 > That's simple. If we don't trust translations anymore we should do it directly in the function. `function __() { return esc_html(…`.
    8 >
    9 > Replying to [comment:9 TomasM]:
    10 > > I follow the development of _s and default WP themes to make my themes better and recently in Twenty Fifteen and _s there was escaping promoted. Now, when I applied those changes to my theme I will have to revert :-/
    11 >
    12 > That over-escaping seems to come from .com which is something I (and nacin, I talked with him before this ticket) don't want to support, especially not for a default theme where we have a type of review process for translations.
    13 >
    14 > > Is there any harm for having escaping in place?
    15 > No harm.
    16 >
    17 > [[BR]]
    18 >
    19 > BTW: Twenty Fifteen wasn't even consistent with this.
     1Thanks for the clarification, much appreciated. [edited for brevity]