WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30728 closed defect (bug) (fixed)

Twenty Fifteen: Search field clear button misaligned

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: fixed-major commit
Focuses: Cc:

Description

The x which appears in the search field in the sidebar is misaligned in Safari on OS X.

Attachments (4)

Screenshot 2014-12-16 14.32.58.png (7.4 KB) - added by johnbillion 5 years ago.
30728.patch (506 bytes) - added by lancewillett 5 years ago.
Remove webkit rules and let Safari style be as the browser chrome itself expects
30728.1.patch (2.6 KB) - added by lancewillett 5 years ago.
Attempt to simplify padding for all search inputs
30728.2.patch (2.8 KB) - added by lancewillett 5 years ago.
Better replacement of all top/bottom padding values in search input rules

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in Slack in #core-themes by iamtakashi. View the logs.


5 years ago

This ticket was mentioned in Slack in #core-themes by iamtakashi. View the logs.


5 years ago

@lancewillett
5 years ago

Remove webkit rules and let Safari style be as the browser chrome itself expects

@lancewillett
5 years ago

Attempt to simplify padding for all search inputs

#3 @lancewillett
5 years ago

New patch attempts to simplify the padding for all search input elements throughout the stylesheet.

@lancewillett
5 years ago

Better replacement of all top/bottom padding values in search input rules

#4 @lancewillett
5 years ago

.2 is more intelligent replacement of top/bottom/left padding values for all search input rules.

Related CSS style note: all values in CSS with a starting 0 in front of a decimal place can be removed: 0.6154em should be .6154em instead for simplicity.

Last edited 5 years ago by lancewillett (previous) (diff)

This ticket was mentioned in Slack in #core by nacin. View the logs.


5 years ago

#6 @lancewillett
5 years ago

In 30945:

Twenty Fifteen: hide search input cancel button. See #30728.

#7 @lancewillett
5 years ago

  • Keywords fixed-major commit added; needs-patch removed

Discussing the leading zero for unit values -- per https://make.wordpress.org/core/handbook/coding-standards/css/#values WP style guide we should leave them as-is.

#8 @johnbillion
5 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 30947:

Twenty Fifteen: hide search input cancel button.

Merges [30945] to the 4.1 branch.

Fixes #30728.

Note: See TracTickets for help on using tickets.