WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30744 closed defect (bug) (fixed)

Twenty Fifteen: Screen reader only search button adds unwanted horizontal space in small screens.

Reported by: iamtakashi's profile iamtakashi Owned by: lancewillett's profile lancewillett
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:

Description (last modified by iamtakashi)

Since [30053], the search button is not hidden but screen reader only. That's good but we also need to get rid of paddings around.

https://cldup.com/3GJi-84wXB.jpg

Added:
In case it's not clear, see the right edge of the screenshot. we can see background color>

Related: #30110

Attachments (1)

30744.diff​ (425 bytes) - added by iamtakashi 10 years ago.
Remove paddings around screen reader only submit button for search.

Download all attachments as: .zip

Change History (8)

@iamtakashi
10 years ago

Remove paddings around screen reader only submit button for search.

#2 @iamtakashi
10 years ago

  • Description modified (diff)

This ticket was mentioned in ​Slack in #core-themes by iamtakashi. ​View the logs.
10 years ago

#4 @iamtakashi
10 years ago

  • Description modified (diff)

#5 @lancewillett
10 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 30953:

Twenty Fifteen: fix styles for screen-reader-only search button in small screens.

Props iamtakashi, fixes #30744.

#6 @johnbillion
10 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @nacin
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30958:

Twenty Fifteen: Final RTL, editor-style, and search padding fixes.

Merges [30953], [30955], [30956] to the 4.1 branch.

Props iamtakashi, alex-ye.
fixes #30744, #30739, #30746.

Note: See TracTickets for help on using tickets.