WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30746 closed defect (bug) (fixed)

Twenty Fifteen: RTL font differences in editor

Reported by: johnbillion Owned by: nacin
Priority: normal Milestone: 4.1
Component: Bundled Theme Version: 4.1
Severity: normal Keywords: commit fixed-major
Cc: Focuses: rtl

Description

Split out from #30743

https://core.trac.wordpress.org/raw-attachment/ticket/30743/2.jpg

The font family in the editor is Tahoma, the font family in Twenty Fifteen is Noto Serif.

Attachments (4)

30746.patch​ (384 bytes ) - added by alex-ye 12 years ago.
30746.1.diff​ (454 bytes ) - added by iamtakashi 12 years ago.
Override font family setting for body.rtl
30746.diff​ (422 bytes ) - added by obenland 12 years ago.
30746.2.diff​ (462 bytes ) - added by iamtakashi 12 years ago.
Add tahoma as a fallback

Download all attachments as: .zip

Change History (14)

@alex-ye
12 years ago

#1 @helen
12 years ago

  • Summary RTL font differences in editor → Twenty Fifteen: RTL font differences in editor

This ticket was mentioned in ​Slack in #core by nacin. ​View the logs.
12 years ago

#3 @SergeyBiryukov
12 years ago

Might be introduced in [29773].

This ticket was mentioned in ​Slack in #core-themes by lancewillett. ​View the logs.
12 years ago

@iamtakashi
12 years ago

Override font family setting for body.rtl

#5 @iamtakashi
12 years ago

Rather than using !important why don't we just override body.rtl? Would there be any issue by doing so?

#6 @lancewillett
12 years ago

Maybe Tahoma as the second fallback before serif?

@obenland
12 years ago

@iamtakashi
12 years ago

Add tahoma as a fallback

#7 @iamtakashi
12 years ago

  • Component Editor → Bundled Theme
  • Keywords has-patch added; needs-patch removed

#8 @lancewillett
12 years ago

In 30956:

Twenty Fifteen: ensure RTL editor font style is consistent with front-end font style.

Props iamtakashi and alex-ye, see #30746.

#9 @lancewillett
12 years ago

  • Keywords commit fixed-major added; has-patch removed

#10 @nacin
12 years ago

  • Owner set to nacin
  • Resolution → fixed
  • Status new → closed

In 30958:

Twenty Fifteen: Final RTL, editor-style, and search padding fixes.

Merges [30953], [30955], [30956] to the 4.1 branch.

Props iamtakashi, alex-ye.
fixes #30744, #30739, #30746.

Note: See TracTickets for help on using tickets.