Opened 10 years ago
Closed 10 years ago
#30748 closed defect (bug) (fixed)
RTL code tags on the About page
Reported by: | johnbillion | Owned by: | nacin |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Help/About | Keywords: | has-patch commit fixed-major |
Focuses: | rtl | Cc: |
Description
Split out from #30743
The <code>
tags on the About page have a direction: ltr
rule applied in common.css but this doesn't seem to be having the desired effect. The closing parenthesis remains RTL.
Do we need yoavf's patch to fix this?
Attachments (1)
Change History (7)
#2
in reply to:
↑ 1
@
10 years ago
- Keywords commit added; 2nd-opinion removed
Replying to alex-ye:
@johnbillion I tried to do it in another way. what you think?! see: 30748.patch
Looks good, makes sense - just a note for the future that RTL CSS files are generated, so don't patch those directly. We use a Grunt-based build process and CSSJanus now with develop.svn - I imagine you are still using the core.svn repo, which contains the generated files.
Note: See
TracTickets for help on using
tickets.
@johnbillion I tried to do it in another way. what you think?! see: 30748.patch