Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#30748 closed defect (bug) (fixed)

RTL code tags on the About page

Reported by: johnbillion's profile johnbillion Owned by: nacin's profile nacin
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Help/About Keywords: has-patch commit fixed-major
Focuses: rtl Cc:

Description

Split out from #30743

https://core.trac.wordpress.org/raw-attachment/ticket/30743/5.jpg

The <code> tags on the About page have a direction: ltr rule applied in common.css but this doesn't seem to be having the desired effect. The closing parenthesis remains RTL.

Do we need yoavf's patch to fix this?

Attachments (1)

30748.patch (269 bytes) - added by alex-ye 9 years ago.

Download all attachments as: .zip

Change History (7)

@alex-ye
9 years ago

#1 follow-up: @alex-ye
9 years ago

@johnbillion I tried to do it in another way. what you think?! see: 30748.patch

#2 in reply to: ↑ 1 @helen
9 years ago

  • Keywords commit added; 2nd-opinion removed

Replying to alex-ye:

@johnbillion I tried to do it in another way. what you think?! see: 30748.patch

Looks good, makes sense - just a note for the future that RTL CSS files are generated, so don't patch those directly. We use a Grunt-based build process and CSSJanus now with develop.svn - I imagine you are still using the core.svn repo, which contains the generated files.

#3 @helen
9 years ago

In 30952:

Ensure inline code examples stay LTR, punctuation and all.

props alex-ye.
see #30748.

#4 @helen
9 years ago

  • Keywords fixed-major added

#5 @alex-ye
9 years ago

@helen Got it. :)

#6 @nacin
9 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 30957:

About page RTL fixes.

Merges [30951] and [30952] to the 4.1 branch.

props helen, alex-ye.
fixes #30743, #30748.

Note: See TracTickets for help on using tickets.