Enable/disable full-height editor doesn't toggle without refreshing

[Clorith]

When toggling the option Enable full-height editor and distraction-free functionality under Screen Options the editor would snap into it's appropriate size in 4.0

In 4.1 it just leaves the full height editor and moves the status bar of it to the end of the document, refreshing the page brings the editor size down as expected.

[iseulde]

Could you give a bit more steps to reproduce?

When I uncheck it, the editor resizes to the height the user set it to before or the default if nothings was set.

[iseulde]

It looks like this only happens when there is no value in the user settings. In PHP there is a fallback to the default and the size can't be less than 50 or more than 5000 if the user setting is used. In JS the value is directly taken from the user settings: var height = window.getUserSetting('ed_size'); on line 685 of editor-expand.js without any additional checks or fallback.

[azaozz]

This is not a regression, that code is exactly the same in 4.0: https://core.trac.wordpress.org/browser/branches/4.0/src/wp-admin/js/editor-expand.js#L638.

Can be annoying if the user turns off editor expand for the first time while editing longer post, "fixes itself" after the first manual resizing of the editor.

[iseulde]

Also relevant for 4.0.2. If too minor, please set to 4.2.

[azaozz]

In 30977:

Editor: when switching editor-expand off for the first time use the default editor height. Props avryl, fixes #30760 for trunk.

[azaozz]

Reopen for eventual 4.1.1 consideration.

[dd32]

Seems like a small enough edgecase to skip 4.0/4.1 inclusion to me, the experience isn't significantly broken, and you do gain the resize handle when disabling DFW/expand.