WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30762 closed defect (bug) (fixed)

Missing context for Next

Reported by: pavelevap Owned by: SergeyBiryukov
Milestone: 4.1.1 Priority: normal
Severity: normal Version: 4.1
Component: I18N Keywords: has-patch i18n-change fixed-major
Focuses: template Cc:
PR Number:

Description

There was "Next" string used for button during installation (with meaning "Continue"). Recently was the same string used for get_the_posts_pagination() (with different meaning "Next post"). We should add context, but I am not sure in which occurence...

Attachments (1)

30762.patch (636 bytes) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
5 years ago

  • Keywords has-patch added

#2 @nacin
5 years ago

  • Keywords i18n-change added
  • Milestone changed from Awaiting Review to 4.1.1

We could *possibly* do this in 4.1.1.

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31071:

Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().

fixes #30762 for trunk.

#4 @SergeyBiryukov
5 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#5 @obenland
5 years ago

  • Focuses template added

#6 @jorbin
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 31082:

Add context for 'Previous' and 'Next' strings in get_the_posts_pagination().

merges [31071] to 4.1 branch

props SergeyBiryukov
fixes #30762 for trunk.

#7 @pavelevap
5 years ago

Another idea without changing any string: We could use "Continue" instead of "Next" (we are using it in similar cases). And for "Next" and "Previous" there is no need for other context. So in the end, there is one more string less and no change for translators... Should I reopen?

#8 @SergeyBiryukov
5 years ago

"Continue" would need a context too. It's currently only used in the admin and would be translated differently in Russian when used for posts.

The change is already announced on Polyglots, and Next/Previous (with a context) seems consistent to me, so I would leave it as is for now.

#9 @pavelevap
5 years ago

SergeyBiryukov: Sure, no problem. We can have context, which is better, but "Next" (without context) could be still removed? I did not find any occurence of "Continue" for posts? "Continue" is used only for buttons to continue some action and it would fit to replace our remaining "Next" (without context)?

#10 @SergeyBiryukov
5 years ago

Ah, I see what you mean. "Next" (without context) is only used in signup_user().

Yep, I guess we could replace it with "Continue", let's create a new ticket for that.

Note: See TracTickets for help on using tickets.