WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#30769 closed defect (bug) (fixed)

Unit Tests: Update @covers in a couple of tests

Reported by: sgrant Owned by: boonebgorges
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

I found a couple of mislabeled @covers tags when running phpunit with coverage-html. The attached patch fixes those two tags.
And this is my first ticket in trac, so it's totally scary. :)

Attachments (1)

patch.diff​ (983 bytes) - added by sgrant 7 years ago.
Update @covers tags

Download all attachments as: .zip

Change History (3)

@sgrant
7 years ago

Update @covers tags

#1 @boonebgorges
7 years ago

  • Milestone changed from Awaiting Review to 4.2

And this is my first ticket in trac, so it's totally scary. :)

Welcome! And fear not :)

Good call on the incorrect annotation. For future reference, functions in the global scope must be referenced as sgrant notes. See ​https://phpunit.de/manual/3.7/en/appendixes.annotations.html#appendixes.annotations.covers

See also #26999.

#2 @boonebgorges
7 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 30976:

Use correct notation for global functions in @covers test annotations.

Props sgrant.
Fixes #30769.

Note: See TracTickets for help on using tickets.