Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#30776 closed defect (bug) (fixed)

Twenty Fifteen: Multisite forms

Reported by: pavelevap Owned by: lancewillett
Priority: normal Milestone: 4.2
Component: Bundled Theme Version: 4.1
Severity: minor Keywords: has-patch needs-refresh
Cc: Focuses:

Description

Multisite registration forms do not look very good...

Attachments (5)

Twenty_Fifteen_Multisite.png​ (47.8 KB ) - added by pavelevap 12 years ago.
30776.diff​ (2.5 KB ) - added by valendesigns 12 years ago.
30776-1.diff​ (2.8 KB ) - added by valendesigns 12 years ago.
Twenty_Fifteen_Multisite_Updated.png​ (108.3 KB ) - added by valendesigns 12 years ago.
30776.2.diff​ (11.5 KB ) - added by iamtakashi 12 years ago.
Style properly multisite forms and pages to follow the theme style.

Download all attachments as: .zip

Change History (14)

#1 @lancewillett
12 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 4.2
  • Severity normal → minor

Hi pavelevap, can you review the other default themes from Twenty Ten to Fourteen also please? I don't think we've accounted for these forms in any of the previous themes specifically.

#2 @pavelevap
12 years ago

Yes, I asked for Twenty Twelve myself: #22179

There was support in Twenty Thirteen: #23631

There was support in Twenty Fourteen: #25479

Basic support should be available (forms, messages) for default themes, I guess.

@valendesigns
12 years ago

#3 @valendesigns
12 years ago

  • Keywords has-patch added; needs-patch removed

This patch should get the ball rolling. It fixes the layout widths and padding for .mu_register on all screens.

#4 @valendesigns
12 years ago

This second patch uses margins for layout and adds a white background and padding inside the container to mimic article styles. It looks much better, and is how I should have done it the first time.

Cheers,
Derek

Last edited 12 years ago by valendesigns (previous) (diff)

#5 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution → fixed
  • Status new → closed

In 30995:

Twenty Fifteen: add styles for multisite registration forms.

Props valendesigns, fixes #30776.

#6 @lancewillett
12 years ago

  • Keywords needs-refresh added
  • Resolution fixed
  • Status closed → reopened

Noted by @iamtakashi that needs a bit more work, including Registration page.

#7 @iamtakashi
12 years ago

Yes. There are still a quite few elements that are left as default and not harmonic with the theme style. We also need to pay more attention to responsive styles, typography, and old IEs. I'm working on a patch.

Last edited 12 years ago by iamtakashi (previous) (diff)

@iamtakashi
12 years ago

Style properly multisite forms and pages to follow the theme style.

#8 @lancewillett
12 years ago

  • Resolution → fixed
  • Status reopened → closed

In 31001:

Twenty Fifteen: more styles for multi-site forms.

Props iamtakashi, closes #30776.

This ticket was mentioned in ​Slack in #core-themes by iamtakashi. ​View the logs.


12 years ago

Note: See TracTickets for help on using tickets.