WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30791 closed defect (bug) (fixed)

Old file missed in TinyMCE Skin

Reported by: MattyRob Owned by: SergeyBiryukov
Milestone: 4.1.1 Priority: low
Severity: trivial Version: 4.1
Component: Upgrade/Install Keywords: has-patch fixed-major
Focuses: Cc:

Description

Between WordPress 4.0.1 and 4.1 a file in:
wp-includes/js/tinymce/skins/wordpress/images/
was renanmed.

'dashicon-no-alt.png' is now named 'dashicon-no.png'

The upgrade process needs to remove the old file

Attachments (2)

30791.diff (498 bytes) - added by kpdesign 5 years ago.
Remove unused image file
30791v2.diff (488 bytes) - added by MattyRob 5 years ago.

Download all attachments as: .zip

Change History (10)

#1 @kpdesign
5 years ago

  • Component changed from General to Upgrade/Install
  • Keywords needs-patch added
  • Version set to 4.1

@kpdesign
5 years ago

Remove unused image file

#2 @kpdesign
5 years ago

  • Keywords has-patch added; needs-patch removed

30791.diff adds unused image file dashicon-no-alt.png to the $_old_files array.

#3 @nacin
5 years ago

  • Milestone changed from Awaiting Review to 4.1.1
  • Priority changed from normal to low
  • Severity changed from normal to trivial

We noticed this when preparing 4.1 for release and decided to not care. :)

We can safely fix this in 4.1.1 since wp-admin/includes/update-core.php is always included in zip packages anyway.

We should label it as "4.1" though. These comments are only for our sanity.

#4 @MattyRob
5 years ago

Updating diff file to simply add this old file to the list of files removed in 4.1 as requested.

@MattyRob
5 years ago

#5 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31073:

TinyMCE: Remove dashicon-no-alt.png, unused since [30694].

props kpdesign, MattyRob.
fixes #30791 for trunk.

#6 @SergeyBiryukov
5 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

This ticket was mentioned in Slack in #core by jorbin. View the logs.


5 years ago

#8 @jorbin
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 31088:

TinyMCE: Remove dashicon-no-alt.png, unused since [30694].

merges [31073] to 4.1 branch.

props kpdesign, MattyRob.
fixes #30791.

Note: See TracTickets for help on using tickets.