WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30793 closed defect (bug) (fixed)

Period should be translated

Reported by: mako09 Owned by: SergeyBiryukov
Milestone: 4.2 Priority: low
Severity: minor Version: 3.0
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

A period of the line https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-upgrader-skins.php#L218 is not tranlatable.

It may be moved to the translated words located just before it.

Or rather it should be removed.

Attachments (3)

30793.patch (1.1 KB) - added by mako09 6 years ago.
move
30793-remove.patch (1.1 KB) - added by mako09 6 years ago.
remove
30793.diff (1.2 KB) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (7)

@mako09
6 years ago

move

@mako09
6 years ago

remove

#1 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 4.2
  • Priority changed from normal to low
  • Severity changed from normal to minor
  • Version changed from 4.1 to 3.0

Done in [14173]. We can fix this in 4.2. Someone would have to look, but removing it might be OK. Or, if we keep it, we should lowercase the "D" in details, I think.

#2 @valendesigns
6 years ago

  • Keywords has-patch added

@DrewAPicture
6 years ago

#3 @DrewAPicture
6 years ago

  • Keywords commit added

I'm in favor of removing the period altogether.

Regenerated @mako09's patch as 30793.diff.

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31506:

Remove untranslatable period from a successful update message in Bulk_Upgrader_Skin::add_strings().

props mako09, DrewAPicture.
fixes #30793.

Note: See TracTickets for help on using tickets.