wp_list_pages() is not closing the </li> in some circumstances

[JeremyVisser]

When wp_list_pages() is called limiting the depth of pages to be listed, it seems to be forgetting the closing </li> sometimes and invalidating the markup.

The arguments passed to it is 'sort_column=menu_order&depth=1&title_li=' and if I remove the depth=1 the markup will validate but will show all the pages, which is not what I want.

I can reproduce the error in the K2 theme, which uses the depth=1 argument.

I think the error is occurring in the Walker_Page class and could be related to #2668 but I don't have the PHP skills to be sure.

[ryan]

(In [4563]) Export file content type fixups from mdawaffe. fixes #3080

[ryan]

Oops. Closed the wrong one.

[ryan]

(In [4564]) Close previous element when depth is hit. fixes #3080

[Michael]

I just got the trunk from SVN, and this problem is still in effect as far as I can tell. Same situation, same code.

Go to ​http://binarybonsai.com to see it (in the menu). I'll gladly send a screenshot of my static page structure, as I think that might be where wp_list_pages() stumbles.

[Michael]

binarybonsai.com static page structure

[markjaquith]

Seems to be the opposite case: redundantly closed </li>

Here's what I see on Binary Bonsai:

<ul class="menu">
	<li class="current_page_item"><a href="http://binarybonsai.com/" title="Blog">Blog</a></li>
	<li class="page_item"><a href="http://binarybonsai.com/archives/" title="Archives">Archives</a></li>
	<li class="page_item"><a href="http://binarybonsai.com/wordpress/" title="WordPress">WordPress</a></li>
</li>
	<li class="page_item"><a href="http://binarybonsai.com/about/" title="About">About</a></li>
</ul>

[Michael]

Yes, my mistake in describing the issue.

[ryan]

(In [4779]) Walker fix ups. fixes #3080