WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30807 closed enhancement (fixed)

Font family titles in Arabic

Reported by: rasheed Owned by: SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: I18N Keywords: has-patch dev-feedback 4.2-beta
Focuses: rtl Cc:
PR Number:

Description

Titles should look differently from the rest of the text.
In Arabic, the font Arial (bold) is the most appropriate font for titles (H1, H2, H3, H4, H5, H6).
Is it possible to apply this rule to all the titles/headings?

Attachments (2)

30807.diff (376 bytes) - added by valendesigns 5 years ago.
30807.1.diff (514 bytes) - added by valendesigns 5 years ago.

Download all attachments as: .zip

Change History (17)

#1 @nacin
5 years ago

  • Component changed from General to I18N
  • Milestone changed from Awaiting Review to 4.2

Sure, we could do that. :)

#2 follow-up: @nacin
5 years ago

A major question would be whether this should apply to all RTL that is in Arial (Hebrew is in Tahoma), or only Arabic.

#3 in reply to: ↑ 2 @rasheed
5 years ago

Replying to nacin:

A major question would be whether this should apply to all RTL that is in Arial (Hebrew is in Tahoma), or only Arabic.

I can say that it fits well into Hebrew too.

@valendesigns
5 years ago

#4 @valendesigns
5 years ago

  • Keywords has-patch added

This patch changes the font stack for .rtl headings to Arial, sans-serif and makes them bold instead of 600.

#5 @valendesigns
5 years ago

  • Keywords dev-feedback added

@nacin Any thoughts on the patch? It's been sitting dormant for a couple months now. I just checked and it still applies cleanly.

#6 @SergeyBiryukov
5 years ago

  • Focuses rtl added

#7 @nacin
5 years ago

Sure, let's do it. @ocean90 or @sergeybiryukov, want to run with this? After commit, we should probably cross-post to make.wordpress.org/polyglots to get follow-up feedback from any other RTL locales.

#8 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

This ticket was mentioned in Slack in #core by drew. View the logs.


5 years ago

#10 @DrewAPicture
5 years ago

  • Keywords 4.2-beta added

@SergeyBiryukov is on the case.

#11 @valendesigns
5 years ago

@SergeyBiryukov Any updates on this one?

This ticket was mentioned in Slack in #core by drew. View the logs.


5 years ago

#13 @ocean90
5 years ago

The styles should be moved to l10n.css.

@valendesigns
5 years ago

#14 @valendesigns
5 years ago

Patch updated, the code has been moved into l10n.css. Cheers!

#15 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 31843:

Use bold Arial for RTL headings.

props valendesigns.
fixes #30807.

Note: See TracTickets for help on using tickets.