WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30820 closed defect (bug) (fixed)

Imagick unit test could randomly fail.

Reported by: voldemortensen's profile voldemortensen Owned by: boonebgorges's profile boonebgorges
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description (last modified by voldemortensen)

In tests/phpunit/tests/image/editor_imagick.php, wp_get_image_editor is used instead of creating a new WP_Image_Editor_Imagick instance. This could potentially cause failures if Imagick is not available.

Attachments (1)

30820.diff​ (814 bytes) - added by voldemortensen 10 years ago.

Download all attachments as: .zip

Change History (6)

@voldemortensen
10 years ago

#1 @voldemortensen
10 years ago

  • Description modified (diff)

This ticket was mentioned in ​Slack in #core by voldemortensen. ​View the logs.
10 years ago

This ticket was mentioned in ​Slack in #core by boone. ​View the logs.
10 years ago

#4 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 4.2

#5 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 30990:

In Imagick tests, instantiate WP_Image_Editor_Imagick directly instead of calling wp_get_image_editor().

This is for greater consistency with other image editor tests.

Props voldemortensen.
Fixes #30820.

Note: See TracTickets for help on using tickets.