I want to add the list table views in edit-tags.php

[llemurya]

I want to add some list table views in edit-tags.php page, but it is not possible without workout ,because in this page on line #326 run only this code <?php $wp_list_table->display(); ?> but I want to see
<?php $wp_list_table->views(); ?>;
<?php $wp_list_table->display(); ?>. In order to add some filters and render views.

[boonebgorges]

I guess I'm not opposed to doing this, but as WP_Terms_List_Table is currently built, the only way you'll be able to add the views markup is by filtering 'views_edit-post_tag' and returning the link markup. IMO this is kind of a lousy UX. Better might be to introduce WP_Terms_List_Table::get_views(), which would return an empty array that'd pass through a 'term_view_links' filter or something like that. Then plugins could add their links in a more sensible way. Do you have thoughts about this?

[boonebgorges]

Still seems like a good idea. Patch needed.

[eventualo]

I've just added the 30829.patch. As suggested by @llemurya I added $wp_list_table->views() in edit-tags.php. So, like @boonebgorges remind us, it's possible to add table views using the views_edit-post_tag hook. I didn't add another filter inside get_views()/views() methods because there aren't similar filters in other posts/media edit files.

[mariovalney]

I refreshed @eventualo patch and added get_views to WP_Terms_List_Table as suggested by @boonebgorges .

The only filter I found on get_views() was comment_status_links so without another filter to compare name I kept the term_view_links suggestion but added taxonomy to support custom ones: term_' . $this->screen->taxonomy . '_view_links

[riddhiehta02]

Add Description to the function. Patch added.

[DrewAPicture]

Assigning ownership to mark the good-first-bug as "claimed".

[boonebgorges]

Thanks to @mariovalney and @riddhiehta02 for your patches!

Could I please get a single, unified patch that does the following:

• includes the description added by @riddhiehta02 in 30829.2.patch​
• has correct indentation for the docblock (see ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#indentation)
• has a @since annotation for the new get_views() method (see ​https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#since-section-changelogs)
• includes the call to get_views() in edit-tags.php from 30829-2.patch​

As long as we get this patch, it should be no problem to add for 4.9.

[mariovalney]

Thanks for guidelines, @boonebgorges.
Thanks for description, @riddhiehta02.

I guess 30829.3.patch is done.

P.S.: sorry for wrong number on 39958.3.patch... hahahah

[boonebgorges]

Thank you, @mariovalney!

Earlier, I said that the views_edit-post_tag filter was cumbersome to use. As I'm reviewing the most recent patches, I'm unsure why I thought this - the proposed new filter in 30829.3.patch​ return exactly the same kind of data as the generic views_{$screen} filter. This is my mistake - my apologies for misreading the code. Any objections to just going with 30829.patch​ ?

[SergeyBiryukov]

In 41378:

Taxonomy: Allow for adding custom list table views to taxonomy screens.

Props eventualo, mariovalney, riddhiehta02, llemurya.
Fixes #30829.