WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 6 months ago

#30855 new defect (bug)

wp_get_update_data() calls are not pluggable

Reported by: szepe.viktor Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.1
Component: Administration Keywords:
Focuses: Cc:
PR Number:

Description

Up to 4.1 I was able to disable core, themes and plugin updates and related HTTP traffic.

https://github.com/szepeviktor/wordpress-plugin-construction/blob/7b64d0ca4981b163b2f08adbe14a5b5238800bd8/mu-disable-updates/disable-updates.php

In 4.1 new wp_get_update_data() calls are much like hardcoded than pluggable, I wasn't able to disable them all. Especially not the ones in wp-admin/menu.php

https://github.com/WordPress/WordPress/blob/master/wp-admin/menu.php#L33-L34
https://github.com/WordPress/WordPress/blob/master/wp-admin/menu.php#L183-L187

Could you make wp_get_update_data() calls pluggable? Or give me an advise to disable them?

My current workaround is to fiddle with the transients:
https://github.com/szepeviktor/wordpress-plugin-construction/blob/master/mu-disable-updates/disable-updates.php#L98

Thank you!

Change History (3)

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 years ago

#2 @jorbin
4 years ago

do the following filters in place already not work for this?

remove_action( 'admin_init', '_maybe_update_core' );
remove_action( 'admin_init', '_maybe_update_plugins' );
remove_action( 'admin_init', '_maybe_update_themes' );

#3 @szepe.viktor
4 years ago

https://github.com/WordPress/WordPress/blob/master/wp-admin/menu.php#L31-L32
Here you can see that wp_get_update_data() is executed without condition.

The only way to make it ineffective is to alter the transient's value.

Actually the transients could contain update data because my mu-plugin allows update by pushing the "Check again" button.

Last edited 4 years ago by szepe.viktor (previous) (diff)
Note: See TracTickets for help on using tickets.