WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30861 closed defect (bug) (fixed)

Media grid all items also shouldn't use full or large sizes

Reported by: oiler Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Media Keywords: has-patch
Focuses: Cc:
PR Number:

Description

This is a follow-up to #29498.

It looks to me like the logic added in #29498 also needs to be applied in line 438 of wp-includes/media-template.php

More to the point, I also strongly argue that using full size as a fallback if 'large' has been deregistered isn't a good idea. This could lead to an initial page load of well over 100MB. Every effort to check for other sizes - specifically the thumbnail size - should be made before loading the full size image into this thumb grid.

Attachments (1)

30861.diff (1.3 KB) - added by wonderboymusic 5 years ago.

Download all attachments as: .zip

Change History (3)

@wonderboymusic
5 years ago

#1 @wonderboymusic
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

Agreed, thanks for the report. I would load thumbnail before full here. 30861.diff

#2 @wonderboymusic
5 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31039:

In Media Grid, don't immediately load full size images if the requested size passed to wp.media.view.Attachment.imageSize() does not exist, look for other suitable sizes.

Fixes #30861.

Note: See TracTickets for help on using tickets.