WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30871 closed defect (bug) (fixed)

'Log out of all other sessions' button overrides Enter key

Reported by: lumpysimon Owned by: jorbin
Priority: normal Milestone: 4.1.1
Component: Users Version: 4.1
Severity: normal Keywords: has-patch commit fixed-major
Cc: Focuses: administration

Description

If the Log out of all other sessions button is showing on the User Profile page, pressing Enter in any form field does not submit the form, instead it logs out the other sessions.

Attachments (1)

30871.patch​ (1.8 KB ) - added by ocean90 12 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
12 years ago

#1 @ocean90
12 years ago

  • Component Administration → Users
  • Focuses administration added
  • Keywords has-patch added
  • Milestone Awaiting Review → 4.1.1

30871.patch​ sets the type attribute to button, default is submit.

#2 @nacin
12 years ago

  • Keywords commit fixed-major added

jorbin in [31010]:

Set the type attribute of the buttons for logging out of all sessions to buttons

By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.

props ocean90
fixes #30871 for trunk

#3 @jorbin
12 years ago

  • Owner set to jorbin
  • Resolution → fixed
  • Status new → closed

In 31076:

Set the type attribute of the buttons for logging out of all sessions to buttons

By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.

merges [31010] to the 4.1 branch

props ocean90

fixes #30871

Note: See TracTickets for help on using tickets.