Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30884 closed defect (bug) (invalid)

Inline Docs: Fix CSS doc block formatting in media-views.css

Reported by: netweb's profile netweb Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: docs Cc:

Description

Per the CSS docs formatting guidelines here CSS multiline comments should be formatted as:

/**
* #.# Section title
*
* Description of section, whether or not it has media queries, etc.
*/

In /src/wp-includes/css/media-views.css#L107 the comment is currently formatted as:

/*!
 * jQuery UI Draggable/Sortable 1.11.2
 * http://jqueryui.com
 *
 * Copyright 2014 jQuery Foundation and other contributors
 * Released under the MIT license.
 * http://jquery.org/license
 */

This causes an issue where the CSS comments are not stripped as part of the minification process of Grunt task cssmin:core

https://cldup.com/h0MX_7qRw4.png

Attachments (1)

30884.diff (313 bytes) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (3)

@netweb
10 years ago

#2 @netweb
10 years ago

  • Milestone 4.2 deleted
  • Resolution set to invalid
  • Status changed from new to closed

Thanks for the feedback and you're correct.

Related discussion in #25926 / r26629, paraphrasing: "Copyright or license needs to be included to comply with the GPL"

Closing as invalid

Note: See TracTickets for help on using tickets.