Move alert boxes with class notice

[sippis]

In #27418 there were added new main class for admin notices, but javascript wasn't updated to work with it.

Right now javascript moves divs "updated" and "error" to the wrap div. This should also be done for divs with class "notice".

Current wp-admin/js/common.js:371-373

// Move .updated and .error alert boxes. Don't move boxes designed to be inline.
$('div.wrap h2:first').nextAll('div.updated, div.error').addClass('below-h2');
$('div.updated, div.error').not('.below-h2, .inline').insertAfter( $('div.wrap h2:first') );

Updating those lines to following fixes this problem

// Move .updated, .error and .notice alert boxes. Don't move boxes designed to be inline.
$('div.wrap h2:first').nextAll('div.updated, div.error, div.notice').addClass('below-h2');
$('div.updated, div.error, div.notice').not('.below-h2, .inline').insertAfter( $('div.wrap h2:first') );

[azaozz]

Thanks @sippis, looks good. Can also reuse one of the selectors and fix the syntax a bit.

[azaozz]

In 31023:

Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices. Props sippis, fixes #30885.

[ocean90]

Moving for 4.1.1 consideration.

[johnbillion]

I think we should pull this JS out altogether and leave admin notices at the top of the page. It causes admin notices to jump around, especially if the browser or the page is slow to load.

Thoughts?

[dd32]

In 31434:

Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices.

Props sippis.
Merges [31023] to the 4.1 branch.
Fixes #30885.

[dd32]

Replying to johnbillion:

I think we should pull this JS out altogether and leave admin notices at the top of the page. It causes admin notices to jump around, especially if the browser or the page is slow to load.

Thoughts?

I think ​we all hate it (slack), and the notices should be output in the correct place in the first place, sounds like something worth looking at in a new ticket