WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30894 closed defect (bug) (fixed)

Parameters added to get_comment_author_link filter missing from edit-form-comment.php

Reported by: jqz's profile jqz Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Comments Keywords: has-patch needs-testing
Focuses: Cc:

Description

wp-includes/comment-template.php adds 2 new parameters to the get_comment_author_link filter in WP 4.1 (lines 209-220). But these are not reciprocated in wp-admin/edit-form-comment.php (line 52). The latter needs updating, if possible, or the change otherwise reviewed as a whole.

Attachments (1)

edit-form-comment.php.patch​ (840 bytes) - added by tyxla 10 years ago.
Amend the get_comment_author_link filter call in wp-admin/edit-form-comment.php to pass all three parameters, as documented in wp-includes/comment-template.php.

Download all attachments as: .zip

Change History (5)

#1 @jqz
10 years ago

Adding null as default parameters to the new extended filter resolves issues with wp-admin; if that is intended, some documentation would be good...

@tyxla
10 years ago

Amend the get_comment_author_link filter call in wp-admin/edit-form-comment.php to pass all three parameters, as documented in wp-includes/comment-template.php.

#2 @tyxla
10 years ago

  • Keywords has-patch needs-testing added

#3 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.2

#4 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31053:

Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092].

props tyxla.
fixes #30894.

Note: See TracTickets for help on using tickets.