WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30908 closed defect (bug) (fixed)

Remove tailing (white)space from size_format()

Reported by: tillkruess Owned by: pento
Milestone: 4.2 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords:
Focuses: Cc:
PR Number:

Description

size_format() returns an unnecessary tailing space if the unite is B.

Attachments (1)

30908.diff (1.3 KB) - added by tillkruess 5 years ago.

Download all attachments as: .zip

Change History (4)

@tillkruess
5 years ago

#1 @tillkruess
5 years ago

Attached patch removed that single space. Patch also includes PHPdoc and WP coding standards updates.

#2 @pento
5 years ago

  • Milestone changed from Awaiting Review to 4.2
  • Owner set to pento
  • Status changed from new to assigned
  • Version changed from trunk to 2.5

#3 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 31052:

size_format() incorrectly included a trailing space for B values: less than 1024 bytes.

Also add a unit test to check for this, so we don't do it again.

Fixes #30908.

Props tillkruess.

Note: See TracTickets for help on using tickets.