Link Manager: Doesn't support relative URLs for "Image Address"

[hartwork]

For links, the "Edit Link" page allows be to put in any of

• http://blog.hartwork.org/__images/gentoo3-150x30.png
• https://blog.hartwork.org/__images/gentoo3-150x30.png
• /__images/gentoo3-150x30.png

for a working image URL but

• it mis-corrects __images/gentoo3-150x30.png to http://__images/gentoo3-150x30.png and
• setting it to //blog.hartwork.org/__images/gentoo3-150x30.png remains untouched but results in broken final URL http://blog.hartwork.org//blog.hartwork.org/__images/gentoo3-150x30.png on the blog itself (which is unexpected).

Without patching code, what are my options?
This behaviour is actually not new in 4.1 btw.

[hartwork]

PS: /__images/gentoo3-150x30.png also ends up pointing to http:// rather than https:// if the blog master URL starts with http:// despite the user viewing the https:// version. I'd expect SSL-support from a relative link. Thanks!

[DrewAPicture]

It definitely seems like the Link Manager doesn't support relative URLs. Not sure whether we're even still supporting enhancements to the this area since it was split off to a plugin a few releases ago.

[SergeyBiryukov]

Replying to DrewAPicture:

It definitely seems like the Link Manager doesn't support relative URLs. Not sure whether we're even still supporting enhancements to the this area since it was split off to a plugin a few releases ago.

All the plugin currently does is to enable the existing UI, so this seems like worthwhile fix.

[tw2113]

I think this issue was originally slightly mis-reported, or has somehow since changed from the time.

This version with the single forward slash at the start appears to work just fine now.

/__images/gentoo3-150x30.png

Without the slash at the front, it's generating the issue still, as well as trying to use the domain without the protocol.

I feel one solution could be with relative paths, check if the link image doesn't start with a single /, prepend for the user. However, trying to check for protocol-less domain may be a bit more code than preferred for a feature that is hidden for majority of the installs. Perhaps something like this for the first variation

} else { // If it's a relative path.
	$sep = '';
	if ( ! str_starts_with( $bookmark->link_image, '/' ) {
		$sep = '/';
	}
	$output .= '<img src="' . get_option( 'siteurl' ) . $sep . $bookmark->link_image . '"' . $alt . $title . ' />';
}

I think this could fix the most appropriate relative URL attempts.