WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30927 closed defect (bug) (fixed)

Replace some 500 errors with 403 errors

Reported by: tomdxw's profile tomdxw Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

As a follow-up to #10551, here's another patch to change a few more 500 errors into 403s.

Attachments (1)

0001-Return-403-responses.patch​ (2.2 KB) - added by tomdxw 10 years ago.

Download all attachments as: .zip

Change History (5)

@tomdxw
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.2

#2 @voldemortensen
10 years ago

  • Keywords has-patch added

#3 @DrewAPicture
10 years ago

  • Keywords commit added

Hi @tomdxw, thanks for the patch. For what it's worth, if you pass the --no-prefix flag when generating your patches with git, it'll skip attaching all of your personal information to the patch.

0001-Return-403-responses.patch​ looks good to me.

#4 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31300:

Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.

props tomdxw.
fixes #30927.

Note: See TracTickets for help on using tickets.