Context Navigation

← Previous Ticket
Next Ticket →

#30928 closed enhancement (fixed)

Small performance improvement of wp_count_posts

Reported by:	minderdl	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.2
Component:	Posts, Post Types	Version:	2.5.1
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

In wp_count_posts() the query is built all the time, even if the results from the cache are used (for which only the cache key is needed). Is there a reason for this?

IMO a small performance improvement can be made by moving the lines building $query inside the "if ( false === $counts )" branch.

Attachments (2)

30928.patch (1.5 KB ) - added by SergeyBiryukov 12 years ago.
30928.diff (1.8 KB ) - added by MikeHansenMe 12 years ago.

Download all attachments as: .zip

Change History (4)

@SergeyBiryukov
12 years ago

Attachment 30928.patch added

@MikeHansenMe
12 years ago

Attachment 30928.diff added

#1 @SergeyBiryukov
12 years ago

Keywords has-patch commit added
Milestone Awaiting Review → 4.2
Version trunk → 2.5.1

Introduced in [7638].

#2 @SergeyBiryukov
12 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

In 31058:

Skip building the query in wp_count_posts() if cached results are used.

props MikeHansenMe.
fixes #30928.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core