Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30938 closed defect (bug) (fixed)

wpview: tinymce.each only stops when returning false, only get all the view offsets when clicking next to the body

Reported by: iseulde's profile iseulde Owned by: azaozz's profile azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.0
Component: TinyMCE Keywords: has-patch
Focuses: javascript Cc:

Description

Currently, whenever there's a click in the editor, there wil be always some expensive calculations from the wpview plugin.

  1. Reduce them to when the click is outside the body.
  2. return alone doesn't actually do anything in a tinymce.each function. return false when the click is above a view or next to a view to stop the loop.

Attachments (1)

30938.patch (1.4 KB) - added by iseulde 10 years ago.

Download all attachments as: .zip

Change History (3)

@iseulde
10 years ago

#1 @iseulde
10 years ago

  • Keywords has-patch added

#2 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31143:

TinyMCE wpView: when clicking in the editor optimize the caret placement before or after a view. Props avryl, fixes #30938.

Note: See TracTickets for help on using tickets.