WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30943 closed defect (bug) (fixed)

Media Library: Duplicate files are confusingly labeled the same on List mode

Reported by: diegoe Owned by: helen
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Media Keywords: has-patch
Focuses: ui, administration Cc:

Description

On Grid mode, elements in your Media Library are labeled by their filename.
On List mode, elements are labeled by their title.

This is confusing if you have uploaded duplicate files.

Possible solutions could be:

  • Add the filename beneath the title the List view.
  • Always use the filename on both modes.
  • Append numbers to the end of the title, like it's done with the filename.

See attached screenshots.

Attachments (7)

Captura de pantalla 2015-01-07 a las 15.00.31.png (37.2 KB) - added by diegoe 6 years ago.
Grid view
Captura de pantalla 2015-01-07 a las 15.00.40.png (49.2 KB) - added by diegoe 6 years ago.
List view
30943.diff (681 bytes) - added by wonderboymusic 6 years ago.
Screen Shot 2015-02-27 at 3.59.23 PM.png (39.9 KB) - added by wonderboymusic 6 years ago.
30943_before.png (92.8 KB) - added by DrewAPicture 6 years ago.
Before (IPhone 6)
30943_after.png (114.7 KB) - added by DrewAPicture 6 years ago.
After (iPhone 6)
30943_grid.png (53.1 KB) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (15)

#1 @SergeyBiryukov
6 years ago

  • Component changed from Upload to Media
  • Focuses ui administration added

#2 @helen
6 years ago

Related, for non-list view: #31395

@wonderboymusic
6 years ago

#3 @wonderboymusic
6 years ago

  • Keywords has-patch ui-feedback added
  • Milestone changed from Awaiting Review to 4.2

30943.diff is the best I could come up with, screenshot attached

#4 follow-up: @helen
6 years ago

If we're showing the full filename, the extension below seems unnecessary. How does that look with long file names on narrower screens?

@DrewAPicture
6 years ago

Before (IPhone 6)

@DrewAPicture
6 years ago

After (iPhone 6)

#5 in reply to: ↑ 4 @DrewAPicture
6 years ago

Replying to helen:

If we're showing the full filename, the extension below seems unnecessary. How does that look with long file names on narrower screens?

Added 30943_before.png and 30943_after.png for a before and after with ridiculously long filenames. Also added 30943_grid.png for grid-view reference.

#6 @helen
6 years ago

It's somewhat more scrolling, but it seems okay. Going to drop the extension/mimetype though, as it's very redundant.

#7 @helen
6 years ago

  • Keywords ui-feedback removed

Made some changes as I was reviewing for commit, some notes about what's about to go in for reference:

  • We just use the GUID instead of going through get_attached_file() in some other places in core, so keeping that here for consistency both in code and in output.
  • Replacing the contents of the paragraph that contained the extension with this instead, and giving that paragraph a class.

#8 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 31857:

Media: Show filename instead of extension in the list table.

This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore.

fixes #30943.

Note: See TracTickets for help on using tickets.