Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30946 closed defect (bug) (fixed)

wp_update_comment() can't update the comment_post_ID

Reported by: tyxla Owned by: pento
Priority: normal Milestone: 4.2
Component: Comments Version: 4.1
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

The current implementation of wp_update_comment() does not allow to change the comment_post_ID - the ID of the post that the comment is posted to. Even if comment_post_ID is passed to the array parameter, it is being stripped off the database update query.

So, the following code:

wp_update_comment(array(
	'comment_ID' => 1,
	'comment_post_ID' => 2,
	'comment_content' => 'test text here',
));

will not change the comment_post_ID to 2, even if 2 is a valid post ID.

Attachments (2)

wp_update_comment.patch (2.4 KB ) - added by tyxla 12 years ago.
Allowing the comment_post_ID to be updated, and if passed, make sure that it corresponds to a valid post ID. Adding a unit test assertion in Tests_Comment::test_wp_update_comment() for that functionality.
30946.diff (2.4 KB ) - added by rachelbaker 12 years ago.
Minor code formatting change from wp_update_comment.patch

Download all attachments as: .zip

Change History (10)

#1 @tyxla
12 years ago

  • Keywords needs-patch needs-unit-tests needs-testing added

#2 @SergeyBiryukov
12 years ago

  • Keywords needs-testing removed

Related: #30307, #30627.

#3 @SergeyBiryukov
12 years ago

  • Milestone Awaiting Review4.2

@tyxla
12 years ago

Allowing the comment_post_ID to be updated, and if passed, make sure that it corresponds to a valid post ID. Adding a unit test assertion in Tests_Comment::test_wp_update_comment() for that functionality.

#4 @tyxla
12 years ago

  • Keywords has-patch added; needs-patch needs-unit-tests removed

@rachelbaker
12 years ago

Minor code formatting change from wp_update_comment.patch

#5 @rachelbaker
12 years ago

Confirmed bug and tested submitted patch. Patch looks good. Added minor formatting adjustment.

Last edited 12 years ago by rachelbaker (previous) (diff)

This ticket was mentioned in Slack in #core by rachelbaker. View the logs.


12 years ago

#8 @pento
12 years ago

  • Owner set to pento
  • Resolutionfixed
  • Status newclosed

In 31195:

Allow comment_post_ID to be passed to wp_update_comment(), so that a comment can be moved to a different post.

Props tyxla, rachelbaker

Fixes #30946

Note: See TracTickets for help on using tickets.