Consider removing old DFW code form core

[iseulde]

Last cycle we decided to try this in 4.2. A plugin could copy the necessary things from 4.1 and hopefully improve it.

[DrewAPicture]

Definitely too late for this in 4.2.

[azaozz]

In 30949.patch: remove the JS and CSS for wp-fullscreen, remove the TinyMCE plugin, deprecate the PHP functions.

Moved the deprecated wp_ajax_wp_fullscreen_save_post() to wp-admin/includes/deprecated.php, but maybe better to leave it in its current place in wp-admin/includes/ajax-actions.php?

[iseulde]

This looks awesome! :)
There seems to be a problem with the patch. I looks like a file is deleted twice.

The next patch would empty out the file src/wp-includes/js/tinymce/plugins/wpfullscreen/plugin.js,
which is already empty!  Assume -R? [n]

[azaozz]

In 32677:

Editor:

• Remove the old DFW.
• Add back-compat stub for wp-fullscreen.js.
• Keep wp_ajax_wp_fullscreen_save_post() for now.

See #30949.

[azaozz]

Keeping this open for a bit longer in case there are bugs or we want to also deprecate wp_ajax_wp_fullscreen_save_post().

[iseulde]

In 32697:

Browserify after [32677]

See #30949.

[obenland]

@azaozz, any decision on deprecating wp_ajax_wp_fullscreen_save_post() yet? Otherwise we could just close it and open bug tickets if any.

[azaozz]

Lets keep it for now. One of the items on the ​editor wish list is to save with AJAX. We will probably reuse this function when that is implemented.

[DrewAPicture]

@azaozz Do you still want to keep wp_ajax_wp_fullscreen_save_post() as soft-deprecated?

The issue has been raised once again in #41121, see ticket:41121:0003-missing-_deprecated_function-calls.patch​

[SergeyBiryukov]

In 41015:

Docs: Update the DocBlock for _WP_Editors::wp_fullscreen_html() after [32677].

See #30949.