WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 5 months ago

#30949 closed enhancement (fixed)

Consider removing old DFW code form core

Reported by: iseulde Owned by: iseulde
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Last cycle we decided to try this in 4.2. A plugin could copy the necessary things from 4.1 and hopefully improve it.

Attachments (1)

30949.patch (52.2 KB) - added by azaozz 3 years ago.

Download all attachments as: .zip

Change History (18)

This ticket was mentioned in Slack in #core by drew. View the logs.


3 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.


3 years ago

#3 @DrewAPicture
3 years ago

  • Keywords needs-patch added

Definitely too late for this in 4.2.

#4 @DrewAPicture
3 years ago

  • Milestone changed from 4.2 to Future Release

This ticket was mentioned in Slack in #core by azaozz. View the logs.


3 years ago

@azaozz
3 years ago

#6 @azaozz
3 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 4.3

In 30949.patch: remove the JS and CSS for wp-fullscreen, remove the TinyMCE plugin, deprecate the PHP functions.

Moved the deprecated wp_ajax_wp_fullscreen_save_post() to wp-admin/includes/deprecated.php, but maybe better to leave it in its current place in wp-admin/includes/ajax-actions.php?

#7 @iseulde
3 years ago

This looks awesome! :)
There seems to be a problem with the patch. I looks like a file is deleted twice.

The next patch would empty out the file src/wp-includes/js/tinymce/plugins/wpfullscreen/plugin.js,
which is already empty!  Assume -R? [n]

This ticket was mentioned in Slack in #core by obenland. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-editor by azaozz. View the logs.


3 years ago

#10 @azaozz
3 years ago

In 32677:

Editor:

  • Remove the old DFW.
  • Add back-compat stub for wp-fullscreen.js.
  • Keep wp_ajax_wp_fullscreen_save_post() for now.

See #30949.

#11 @azaozz
3 years ago

Keeping this open for a bit longer in case there are bugs or we want to also deprecate wp_ajax_wp_fullscreen_save_post().

#12 @iseulde
3 years ago

In 32697:

Browserify after [32677]

See #30949.

#13 @obenland
2 years ago

  • Owner set to iseulde
  • Status changed from new to assigned

#14 @obenland
2 years ago

@azaozz, any decision on deprecating wp_ajax_wp_fullscreen_save_post() yet? Otherwise we could just close it and open bug tickets if any.

#15 @azaozz
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Lets keep it for now. One of the items on the editor wish list is to save with AJAX. We will probably reuse this function when that is implemented.

#16 @DrewAPicture
6 months ago

@azaozz Do you still want to keep wp_ajax_wp_fullscreen_save_post() as soft-deprecated?

The issue has been raised once again in #41121, see ticket:41121:0003-missing-_deprecated_function-calls.patch

#17 @SergeyBiryukov
5 months ago

In 41015:

Docs: Update the DocBlock for _WP_Editors::wp_fullscreen_html() after [32677].

See #30949.

Note: See TracTickets for help on using tickets.