Wrong error message when uploading non-zip files on the plugin upload page

[jnhghy]

If you go to plugins -> upload plugin and you try to insall a .php file instead of a zip file you get this error message: Abort class-pclzip.php : Missing zlib extensions.
This error message is bad, zlib extensions are not missing, the file type is wrong.

Also this message is missing translation support (I might be wrong on this).

[dd32]

A non-zip currently errors out with the following message, which is pretty terrible, I agree.

The package could not be installed. PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature

The error outlined in the ticket here, Abort class-pclzip.php : Missing zlib extensions occurs when the PHP installation is missing both ZipArchive support, and doesn't contain gzopen() (ie. missing zlib extension, or that ubuntu bug #30213). In this case all update-related functionality doesn't work, and we don't appear to check support properly.

[dd32]

Replying to dd32:

The error outlined in the ticket here, Abort class-pclzip.php : Missing zlib extensions occurs when the PHP installation is missing both ZipArchive support, and doesn't contain gzopen() (ie. missing zlib extension, or that ubuntu bug #30213). In this case all update-related functionality doesn't work, and we don't appear to check support properly.

Small clarification: If the install has ZipArchive support, but no gzopen() available, and a non-zip is uploaded, it'll also hit the above conditional, which is currently wrapped in a die()

[DrewAPicture]

@jnhghy If you were interestedin submitting a patch to improve this error message, I could get behind that.