#30972 closed defect (bug) (fixed)
Better support for multi-line comments in StringExtractor
Reported by: | SergeyBiryukov | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | 3.8 |
Component: | I18N | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Background: #30603
Twenty Fourteen's translator comment is missing from GlotPress, because translator comments currently cannot start with an empty line, see [25908].
A simple fix is just to remove the empty line.
However, there's a minor issue in our extract script that causes an extra asterisk to appear in the comment text (currently displayed for Twenty Twelve and Twenty Thirteen, see the screenshot).
The patch fixes both the empty line and the stray asterisk issues.
This would also allow us to revert [30790] for Twenty Fifteen. Squeezing translator comments into a single line makes the file harder to read and should not be necessary.
Attachments (2)
Change History (10)
#3
in reply to:
↑ 2
@
10 years ago
- Keywords commit added
Replying to DrewAPicture:
30972.patch still applies. @SergeyBiryukov: What's left here?
Should be good to go, just wanted a second look from @ocean90. Would committing the patch be enough to be able to revert [30790], or some kind of deploy will be needed on the WP.org side?
#6
@
10 years ago
Committed to i18n.trac as well, since it's currently used for generating POT files.
Nice, all for reverting r30790 :)