Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#30972 closed defect (bug) (fixed)

Better support for multi-line comments in StringExtractor

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: ocean90's profile ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.8
Component: I18N Keywords: has-patch commit
Focuses: Cc:


Background: #30603

Twenty Fourteen's translator comment is missing from GlotPress, because translator comments currently cannot start with an empty line, see [25908].

A simple fix is just to remove the empty line.

However, there's a minor issue in our extract script that causes an extra asterisk to appear in the comment text (currently displayed for Twenty Twelve and Twenty Thirteen, see the screenshot).

The patch fixes both the empty line and the stray asterisk issues.

This would also allow us to revert [30790] for Twenty Fifteen. Squeezing translator comments into a single line makes the file harder to read and should not be necessary.

Attachments (2)

30972.extra-asterisk.png (12.7 KB) - added by SergeyBiryukov 9 years ago.
30972.patch (1.8 KB) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (10)

#1 @netweb
9 years ago

Nice, all for reverting r30790 :)

#2 follow-up: @DrewAPicture
9 years ago

30972.patch still applies. @SergeyBiryukov: What's left here?

#3 in reply to: ↑ 2 @SergeyBiryukov
9 years ago

  • Keywords commit added

Replying to DrewAPicture:

30972.patch still applies. @SergeyBiryukov: What's left here?

Should be good to go, just wanted a second look from @ocean90. Would committing the patch be enough to be able to revert [30790], or some kind of deploy will be needed on the side?

#4 @ocean90
9 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

#5 @ocean90
9 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 31498:

i18n tools: Improve support for multi-line comments in StringExtractor.

props SergeyBiryukov.
fixes #30972.

#6 @ocean90
9 years ago

Committed to i18n.trac as well, since it's currently used for generating POT files.

#7 @ocean90
9 years ago

In 31500:

Revert [30790] and update POT file for Twenty Fifteen.

see #30972, #30603.

#8 @ocean90
9 years ago

In 31501:

Update POT file for Twenty Fourteen.

props SergeyBiryukov.
see #30972, #30603.

Note: See TracTickets for help on using tickets.