WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30980 closed defect (bug) (fixed)

Row actions not revealed on focus in categories and tags screens

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Taxonomy Keywords: has-patch 2nd-opinion
Focuses: ui, accessibility, javascript, administration Cc:
PR Number:

Description

When tabbing through the categories and tags list tables, row actions should be revealed when their container is focused.

Attachments (1)

30980.patch (782 bytes) - added by afercia 5 years ago.

Download all attachments as: .zip

Change History (8)

@afercia
5 years ago

#1 @afercia
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Component changed from Administration to Taxonomy
  • Focuses administration added
  • Milestone changed from Awaiting Review to 4.2

#3 follow-up: @SergeyBiryukov
5 years ago

I think we can replace .bookmarks td.column-name with td.column-name, which would work for categories and tags too.

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31173:

Reveal row actions on focus on taxonomy screens.

props afercia.
fixes #30980.

#5 in reply to: ↑ 3 ; follow-up: @afercia
5 years ago

  • Keywords 2nd-opinion added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to SergeyBiryukov:

I think we can replace .bookmarks td.column-name with td.column-name

Thanks very much Sergey. Not arguing, just to have a second opinion: .bookmarks was there to target just the Link Manager which is no more in core but still available as a plugin, as far as I know. Not sure if we should take this into consideration.
Using just td.column-name will target also table cells that don't need those event bound, for example the Users table has a td.column-name but doesn't use row-actions at all.
As reference, the original commit was r25595

#6 in reply to: ↑ 5 @SergeyBiryukov
5 years ago

Replying to afercia:

Using just td.column-name will target also table cells that don't need those event bound, for example the Users table has a td.column-name but doesn't use row-actions at all.

You're right, let's restore .bookmarks and go with your patch.

#7 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 31177:

Revert [31173] and target only taxonomy and link manager tables in keyboard focus code.

props afercia.
fixes #30980.

Note: See TracTickets for help on using tickets.