Make WordPress Core

Opened 9 years ago

Last modified 3 years ago

#31039 reviewing enhancement

Move retrieve_password() from wp-login.php

Reported by: jfarthing84's profile jfarthing84 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch dev-feedback needs-refresh
Focuses: Cc:


Once considered in #20279, I am able to propose a sane way to separate retrieve_password() from wp-login.php.

Attachments (4)

31039.patch (11.9 KB) - added by jfarthing84 9 years ago.
Separate retrieve_password() from wp-login.php
31039.3.patch (10.9 KB) - added by dimadin 9 years ago.
31039.2.patch (11.3 KB) - added by jfarthing84 6 years ago.
31039.4.patch (10.0 KB) - added by jfarthing84 6 years ago.

Download all attachments as: .zip

Change History (13)

9 years ago

Separate retrieve_password() from wp-login.php

#1 @jfarthing84
9 years ago

  • Keywords has-patch dev-feedback added

#2 @dimadin
9 years ago

I propose that we don't add new functions like in previous patch and instead we just copy existing function, introduce new parameter to switch from reliance on $_POST inside of a function.

There is quick and untested patch attached below to give you an impression.

Also, @jfarthing84 hasn't mentioned why should we do this. Thing is that it's impossible to retrieve password the other way than creating your own function. For example, lets say that you have a custom login form outside wp-login.php, you can't access this function so you need to create new one. I already did this a couple of times so that why I'm proposing making this function available to all users.

9 years ago

#3 @jfarthing84
8 years ago

  • Type changed from defect (bug) to enhancement

#4 @jfarthing84
6 years ago

  • Keywords needs-refresh added

I would love to see this get into core. I am ready to rebase my patch if a developer would chime in.

6 years ago

#5 @jfarthing84
6 years ago

Disregard 31039.2.patch as I accidentally included some changes from another proposed patch.

6 years ago

#6 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.0
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#7 @SergeyBiryukov
6 years ago

  • Milestone changed from 5.0 to 5.1

#8 @pento
5 years ago

  • Milestone changed from 5.1 to Future Release

This ticket needs reviewing and further consideration.

#9 @SergeyBiryukov
3 years ago

In 50140:

Users: Move retrieve_password() to wp-includes/user.php, for consistency with other user functions.

Follow-up to [25231], [50129].

Props jfarthing84, dimadin.
See #34281, #31039.

Note: See TracTickets for help on using tickets.