Move retrieve_password() from wp-login.php

[jfarthing84]

Once considered in #20279, I am able to propose a sane way to separate retrieve_password() from wp-login.php.

[jfarthing84]

Separate retrieve_password() from wp-login.php

[dimadin]

I propose that we don't add new functions like in previous patch and instead we just copy existing function, introduce new parameter to switch from reliance on $_POST inside of a function.

There is quick and untested patch attached below to give you an impression.

Also, @jfarthing84 hasn't mentioned why should we do this. Thing is that it's impossible to retrieve password the other way than creating your own function. For example, lets say that you have a custom login form outside wp-login.php, you can't access this function so you need to create new one. I already did this a couple of times so that why I'm proposing making this function available to all users.

[jfarthing84]

I would love to see this get into core. I am ready to rebase my patch if a developer would chime in.

[jfarthing84]

Disregard 31039.2.patch as I accidentally included some changes from another proposed patch.

[pento]

This ticket needs reviewing and further consideration.

[SergeyBiryukov]

In 50140:

Users: Move retrieve_password() to wp-includes/user.php, for consistency with other user functions.

Follow-up to [25231], [50129].

Props jfarthing84, dimadin.
See #34281, #31039.

[ironprogrammer]

Per [50140] noted in comment:9, this ticket can be marked fixed. I believe this change shipped in 5.8, so setting milestone accordingly.

[ironprogrammer]

Correcting the milestone. Props @dmsnell for helping me figure this out.