Make WordPress Core

Opened 12 years ago

Closed 4 years ago

Last modified 4 years ago

#31040 closed defect (bug) (fixed)

When changing post date from future date to another future date, status being wrongly changed to "Publish on".

Reported by: tyxla Owned by: joedolson
Priority: normal Milestone: 6.3
Component: Editor Version: 3.0
Severity: minor Keywords: has-patch has-screenshots commit
Cc: Focuses: ui, accessibility, javascript

Description

Steps to reproduce:

  1. Create a new post, make it "Scheduled" for a future date.
  2. Save the post.
  3. Change the date to a different date in the future.
  4. The status text is changed to "Publish on" (or "Published on" on older WordPress versions), while it should remain "Scheduled".

Attachments (3)

31040.patch​ (608 bytes ) - added by tyxla 12 years ago.
Fixing the issue by removing the unnecessary post status check.
31040.jpg​ (36.7 KB ) - added by tyxla 11 years ago.
Screenshot of the issue
31040.1.diff​ (672 bytes ) - added by joedolson 4 years ago.
Refreshed patch

Download all attachments as: .zip

Change History (20)

#1 @tyxla
12 years ago

Related ticket: #12751 - applies a similar fix (on the backend side), but for the "publish" post status.

Last edited 12 years ago by SergeyBiryukov (previous) (diff)

#2 @tyxla
12 years ago

  • Keywords needs-patch added

@tyxla
12 years ago

Fixing the issue by removing the unnecessary post status check.

#3 @tyxla
12 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#5 in reply to: ↑ description @sdavis2702
11 years ago

I'm having trouble replicating this, @tyxla.

The status text is changed to "Publish on" (or "Published on" on older WordPress versions), while it should remain "Scheduled".

Where should I be seeing the text change? I looked all around and don't see it. I'm on 4.4-alpha. A screenshot would be perfect. I'll test the patch but I need to replicate first. Thanks!

#6 @tyxla
11 years ago

@sdavis2702 Thanks for your interest!

I am still able to reproduce the issue.

In order to reproduce, in step 3, after changing the date to a different future date, click the "OK" button.

Then observe the text that appears before the date - it changes from "Scheduled for:" to "Published on:".

I'll attach a screenshot of the issue to help you locate it.

Also, the patch still applies cleanly and fixes the issue for me when I'm testing.

@tyxla
11 years ago

Screenshot of the issue

#7 @tyxla
11 years ago

  • Keywords has-screenshots added

#8 @sdavis2702
11 years ago

Ah! Good catch there. That was hard to notice. The patch works perfectly for me on 4.4-beta3-20151105.

#9 @tyxla
11 years ago

  • Keywords needs-testing removed

Great, thanks for testing :)

#10 @joedolson
4 years ago

  • Milestone → 6.3
  • Owner set to joedolson
  • Status new → accepted

@joedolson
4 years ago

Refreshed patch

#11 @joedolson
4 years ago

  • Keywords commit added

For such a small change, this has been lingering way too long! Patch looks good.

#12 @joedolson
4 years ago

  • Component Administration → Editor

#13 @joedolson
4 years ago

  • Focuses accessibility added

Marking this as accessibility, as clarity and consistency of instructions is important for cognitive impairments.

This ticket was mentioned in ​PR #4249 on ​WordPress/wordpress-develop by ​@joedolson.


4 years ago
#14

In the classic editor, fix the publish status change text shown when a future post's date is changed to a different future date. Show 'scheduled' statement instead of 'publish' statement.

Trac ticket: https://core.trac.wordpress.org/ticket/31040

#15 @joedolson
4 years ago

  • Severity normal → minor

#16 @joedolson
4 years ago

  • Resolution → fixed
  • Status accepted → closed

In 55561:

Editor: Show scheduled text when changing to new future dates.

In the classic editor, fix the publish status change text shown when a future post's date is changed to a different future date. Show 'scheduled' statement instead of 'publish' statement.

Props tyxla, sdavis2702, joedolson.
Fixes #31040.

​@joedolson commented on ​PR #4249:


4 years ago
#17

Fixed in r55561

Note: See TracTickets for help on using tickets.