WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#31068 closed enhancement (maybelater)

oEmbed Podbean player support podbean.com embed player URLs

Reported by: podbean Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.1
Component: Embeds Keywords: has-patch needs-refresh 2nd-opinion
Focuses: Cc:

Description

Attached patch provides the support for Podbean embed player in oEmbed endpoint URLs like [embed]http://www.podbean.com/media/player/54bvw-531545/initByJs/1/auto/1?skin=10[/embed] It would be nice if the core regex also handled Podbean oEmbed URLS

Attachments (1)

podbean.patch (805 bytes) - added by podbean 3 years ago.
oEmbed for Podbean embed player

Download all attachments as: .zip

Change History (14)

@podbean
3 years ago

oEmbed for Podbean embed player

#2 in reply to: ↑ 1 @podbean
3 years ago

Replying to SergeyBiryukov:

For reference: http://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers

We, Podbean.com, is one of the largest podcast hosting service providers. We currently have 700k+ members. Many of our users embed their Podbean player in their wordpress blogs. Currently, the player is embed with iframe.
We were contacted by one of wordpress team members and were suggested to create oEmbed function for wordpress core. Would you please let me know where is the right place to submit the oEmbed patch ?

#3 @SergeyBiryukov
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

This is the right place. I've just added a link describing the considerations we generally make when deciding whether to add support for an oEmbed provider.

Moving for review.

#4 follow-up: @johnbillion
3 years ago

  • Keywords reporter-feedback added

What's the status of SSL support on Podbean? See #28507.

#5 in reply to: ↑ 4 @podbean
3 years ago

Replying to johnbillion:

What's the status of SSL support on Podbean? See #28507.

Podbean support both http and https

[embed]https://www.podbean.com/media/player/q6ipb-53431d/initByJs/1/auto/1[/embed]
[embed]http://www.podbean.com/media/player/q6ipb-53431d/initByJs/1/auto/1[/embed]

Both above oEmbed code will work.

Version 0, edited 3 years ago by podbean (next)

This ticket was mentioned in Slack in #core by drew. View the logs.


3 years ago

#7 @DrewAPicture
3 years ago

  • Keywords needs-refresh added; reporter-feedback removed

The patch is out of date and needs to be refreshed. Any consensus here on including Podbean as an oEmbed provider for 4.2?

This ticket was mentioned in Slack in #core by drew. View the logs.


3 years ago

#9 @jorbin
3 years ago

  • Milestone 4.2 deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Right now, I don't think podbean fits our requirements for inclusion for oembed providers. During a quick straw poll of four committers, only one had heard of podbeans. While none of our existing oembed providers are focused on podcasts, the ones that we have focused on music (the closest category I could think of) all have considerably larger twitter bases. Additionally, the lack of a Wikipedia page doesn't assist in demonstrating that podbean is a a service that fit's the description of "well-established, popular, and mainstream services".

I would love to see a standalone WordPress plugin adding oembed support for podbean. An example of one is this kickstarter one. This plugin gaining traction would really help with a different decision in the future. Additionally, having a verified twitter account would help with that decision.

#10 follow-up: @grantbrown
2 years ago

  • Keywords 2nd-opinion added
  • Resolution maybelater deleted
  • Status changed from closed to reopened

I'm the project manager for a large WordPress site, Liberty.me, and I just wanted to drop in to say that we would appreciate oEmbed support for Podbean. We would like to use it for our podcasts section but the lack of oEmbed support has so far prevented us from doing so. Podbean is notable to us because their stat tracking capabilities exceed anything else on the market that we've managed to discover. Thanks for your consideration!

#11 in reply to: ↑ 10 @helen
2 years ago

  • Resolution set to maybelater
  • Status changed from reopened to closed

Replying to grantbrown:

I just wanted to drop in to say that we would appreciate oEmbed support for Podbean. We would like to use it for our podcasts section but the lack of oEmbed support has so far prevented us from doing so.

Additional oEmbed providers can be whitelisted via plugin. The existence and adoption of a plugin can also help us to decide when to bring a provider into core's whitelist, so I would suggest that a plugin be made for Podbean, if there isn't one already.

#12 follow-up: @phongmedia
2 years ago

I was easily able to add Podbean support to my website via the oembed_providers filters, as such:

/**
 * Add Support for PodBean Embed URLs
 * @link https://core.trac.wordpress.org/ticket/31068
 * @see wp_oembed_get()
 * @param $providers [array] Existing oEmbed Providers
 * @return [array] Providers with custom additions
 */
function theme_oembed_providers( $providers ){
	// Add Support for Podbean Player URLs like
	// http://www.podbean.com/media/player/hk8en-5329e8/initByJs/1/auto/1
	$providers['#https?://(www\.)?podbean\.com/media/player/.*#i'] = array( 'http://www.podbean.com/media/oembed', true );
	return $providers;
}
add_filter( 'oembed_providers', 'theme_oembed_providers' );

#13 in reply to: ↑ 12 @grantbrown
2 years ago

Replying to phongmedia:

I was easily able to add Podbean support to my website via the oembed_providers filters, as such:

Thanks, will give this a shot.

Note: See TracTickets for help on using tickets.