wp_register_script|style() should return boolean success/failure value

[katzwebdesign]

wp_register_script() currently returns no value. When registering a script fails, it fails silently.

The wp_register_script() function is essentially a wrapper for $wp_scripts->add(), so wp_register_script() should return the same boolean "True on success, false on failure." value.

[katzwebdesign]

Have the wp_register_script() function return boolean passed by $wp_scripts->add()

[SergeyBiryukov]

This would apply to wp_register_style() as well.

[katzwebdesign]

Have the wp_register_script() and wp_register_style() functions return boolean on success/fail

[katzwebdesign]

Replying to SergeyBiryukov:

This would apply to wp_register_style() as well.

Done!

[pareshradadiya]

PHPUnit test case added

[DrewAPicture]

Tests + changes combined + docs

[DrewAPicture]

31126.2.diff​ combines the changes with the tests, adds changelog entries for the added return values. Let's pick this up in 4.3-early.

[DrewAPicture]

Updated changelogs

[DrewAPicture]

31126.3.diff​ updates the changelog entries to 4.3.0, and simplifies/self-documents the return values in both contexts. Looks good to me.

[obenland]

Would $registered or $is_registered be more descriptive than $add_result? That could also mean adding up results or something.

[DrewAPicture]

$registered

[DrewAPicture]

Replying to obenland:

Would $registered or $is_registered be more descriptive than $add_result? That could also mean adding up results or something.

Changed to $registered in 31126.4.diff​.

[DrewAPicture]

Reassigning for code committer review.

[johnbillion]

In 32483:

Add a return value to wp_register_script() and wp_register_style() which matches the return value of WP_Dependencies::add().

Props katzwebdesign, pareshradadiya, DrewAPicture.

Fixes #31126