register_post_type() should call a _doing_it_wrong() when called with an empty post type name

[tyxla]

If you misuse register_post_type() with an empty string as a first parameter, this will currently not throw any notice.

Anyway, it is definitely wrong and can lead to some very weird results both in the administration and in the frontend.

I suggest that a _doing_it_wrong() should be called to cover this case.

[tyxla]

Adding a _doing_it_wrong() when register_post_type() is called with an empty post type name.

[toscho]

Do we really have to catch every possible edge case?

Besides that, there is now too much code duplication, because you suggested the same thing for #31135. If we really do this, the code should be separated to a function like wp_str_min_max( $str, $min, $max, $encoding ) or something similar.

[DrewAPicture]

As I suggested on #31135, I think we can double up on the _doing_it_wrong() call by defining the minimum and maximum in the same condition and string. It would be also be helpful to have a unit test to cover the empty string case.

[tyxla]

@DrewAPicture yeah, all makes sense, thanks. A single _doing_it_wrong() call would be better, and unit tests would be needed here. Let me attach a patch. Since there is no unit test for the maximum post type length, I'll add one for that too.

[tyxla]

Updating first patch. Now using a single _doing_it_wrong() call for both post type min and max, also adding unit tests for both cases.

[DrewAPicture]

Replying to tyxla:

Since the issues between registering taxonomies and post types are fairly aligned, see comment:5:ticket:31135 for how I would approach the tests for this, except for post types instead of taxonomies. The difference of course would be that there isn't currently a test that I can find for either short or long post types.

So in this case, maybe creating a single test_register_post_type_length() would suffice, again, following similar syntax to that of test_register_long_taxonomy() – in terms of:

• Notating the ticket number
• Using @expectedIncorrectUsage
• Checking for the WP_Error object to confirm instead of the _doing_it_wrong()

[tyxla]

Thanks for your suggestions, they definitely make things better. Attaching an updated patch again.

[tyxla]

Updating unit tests as per @DrewAPicture's suggestions

[DrewAPicture]

Related: #28683

[MikeHansenMe]

uses empty and splits unit tests

[MikeHansenMe]

skip assigning length to variable since we only need it once

[mattheweppelsheimer]

+1 to this ticket. Looks like #28683 didn't go far enough.

[johnbillion]

In 31450:

Return a WP_Error if an empty name is provided when registering a post type.

Fixes #31134
Props tyxla, MikeHansenMe

[SergeyBiryukov]

In 31457:

Use more descriptive names for register_post_type() and register_taxonomy() tests with too long and too short names.

see #31134, #31135.