Allow editing of video embed parameters in the media modal

[melchoyce]

Unsure if this is possible, but it would be pretty sweet if you could adjust available video embed parameters, such as height/width, straight from the media modal. It could fit pretty well on this screen: ​https://cloudup.com/caoYOVuWM41

[wonderboymusic]

The attached code works for editing embeds, but needs a cleaner UI

[wonderboymusic]

31139.2.diff​ is a better UI and mostly works, only problem being: there are some cases were we need to transition from a URL to an [embed] when the width and/or height changes. This currently doesn't work because of how MCE views find themselves in the DOM. Will ping @iseulde

[iseulde]

I'll try to fix this in the next patch. We should auto detect the new view text and update everything accordingly. Currently you can't change the view's type.

[melchoyce]

Can someone with the patch applied post a screenshot? Thanks!

[iseulde]

Scott posted a video here: ​https://wordpress.slack.com/archives/core/p1424979075000063

[melchoyce]

Thanks!

[iseulde]

This currently doesn't work because of how MCE views find themselves in the DOM. Will ping @iseulde

@wonderboymusic Tweaked the API. :) Haven't looked at the encoding problem though, but will fix!

[wonderboymusic]

In 31620:

Allow inline editing of width and height parameters while previewing an embed in the media modal:

• Use wp.shortcode() instead of manually constructing a shortcode in views/embed/link
• Allow a URL to transition to a shortcode (and vice versa) when returning an embed to TinyMCE
• In WP_Embed, store the last URL and last set of attributes requested in class properties
• wp_ajax_parse_embed(), allow [embed]s to have attributes. Return attr in the response.

This is a first pass to allow broad testing with recent MCE view changes.

See #31139.

[wonderboymusic]

In 31626:

After [31620], when checking for HTTP URLs, make sure we are checking the shortcode body instead of an indexed attribute.

See #31139.

[helen]

In 31642:

Media: UI tweaks for Insert from URL.

"Title" field is now labeled as "Link Text", to reflect how it's actually used. It's also hidden whenever the embed is updating, to make it clearer that something is happening. Embed dimension fields are shown below the preview, much like image property fields are shown below.

fixes #29476, see #31139.

[DrewAPicture]

This will ride into Beta 1, see [31620], [31626], and [31642].

[helen]

Do we have any problems here with recent view changes, and/or is the encoding issue fixed now? Not sure if anything else was left here.

[wonderboymusic]

[31819] and [31817] completely broke embeds. Reverting them makes everything work fine. #dark

[helen]

@wonderboymusic Is that something that needs to be fixed in this ticket or is this one done?

[iseulde]

Remaining issues fixed in [31832].

[helen]

Per #32006 and as confirmed in testing, this isn't working in 4.2-RC3. Let's revert and try again later, perhaps with a more unified-feeling look. Right now they just kind of hang out under the video and you don't even see the fields half the time.

[azaozz]

31139.patch works well here.

[DrewAPicture]

31139.patch​ looks good.

[azaozz]

In 32258:

Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.

[iseulde]

#32035:

Not sure the current usage of _.debounce is correct when embedding a link from "Insert from URL". To my understanding, the updateoEmbed function should not be debounced and fetch should be debounced instead.
See discussion about _.debounce on #26600

[iseulde]

Sorry, this was not reverted. Ignore the link.

[wonderboymusic]

In 32330:

After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.

• Use wp.shortcode() instead of manually constructing a shortcode in views/embed/link
• In WP_Embed, store the last URL and last set of attributes requested in class properties
• wp_ajax_parse_embed(), allow [embed]s to have attributes. Return attr in the response.

See #31139.

[melchoyce]

@matias @joen Do you think we can close this now that Gutenberg has the Inspector for media embeds?