TinyMCE Help button is irrelevant on devices without keyboards

[siobhan]

When working on a device without a keyboard, the TinyMCE help text is irrelevant as it provides information on keyboard shortcuts.

I suggest either:

a) providing contextual help text
b) removing the button entirely <--- my preference since I'm not sure what help we need to provide there

[iseulde]

+1 Thanks for all the feedback! :)

[ryan]

b) works for me.

[MattyRob]

Not sure if this is a very elegant patch but it works

[iseulde]

Not sure if this is a very elegant patch but it works

Better to patch the editor class for this. :)
Let's see if this is good to go in.

[MattyRob]

Wouldn't it be better to apply the filter at the end of the button array construction like the updated patch?

[ryan]

v2.patch wouldn't apply for me so I tested with 31161.patch. Help was hidden on iPhone 6+ and iPad Air but showed on Macnchrome, as expected.

$ patch -p0 < ~/Downloads/31161v2.patch 
patching file src/wp-includes/class-wp-editor.php
patch: **** malformed patch at line 18:  				 * Filter the third-row list of TinyMCE buttons (Visual tab).

[ocean90]

In 31718:

Editor: Hide TinyMCE help button on mobile.

props MattyRob, iseulde.
fixes #31161.