WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#31161 closed enhancement (fixed)

TinyMCE Help button is irrelevant on devices without keyboards

Reported by: siobhan Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: make-flow has-patch
Focuses: Cc:

Description

When working on a device without a keyboard, the TinyMCE help text is irrelevant as it provides information on keyboard shortcuts.

I suggest either:

a) providing contextual help text
b) removing the button entirely <--- my preference since I'm not sure what help we need to provide there

Attachments (3)

31161.diff (772 bytes) - added by MattyRob 5 years ago.
31161.patch (978 bytes) - added by iseulde 5 years ago.
31161v2.patch (1017 bytes) - added by MattyRob 5 years ago.

Download all attachments as: .zip

Change History (13)

#1 @siobhan
6 years ago

  • Keywords make-flow added

#2 @iseulde
6 years ago

  • Keywords needs-patch added

+1 Thanks for all the feedback! :)

#3 @ryan
5 years ago

b) works for me.

#4 @MattyRob
5 years ago

  • Keywords has-patch added; needs-patch removed

Not sure if this is a very elegant patch but it works

@MattyRob
5 years ago

@iseulde
5 years ago

#5 @iseulde
5 years ago

  • Milestone changed from Awaiting Review to 4.2

Not sure if this is a very elegant patch but it works

Better to patch the editor class for this. :)
Let's see if this is good to go in.

#6 @MattyRob
5 years ago

Wouldn't it be better to apply the filter at the end of the button array construction like the updated patch?

@MattyRob
5 years ago

#7 @ryan
5 years ago

v2.patch wouldn't apply for me so I tested with 31161.patch. Help was hidden on iPhone 6+ and iPad Air but showed on Macnchrome, as expected.

$ patch -p0 < ~/Downloads/31161v2.patch 
patching file src/wp-includes/class-wp-editor.php
patch: **** malformed patch at line 18:  				 * Filter the third-row list of TinyMCE buttons (Visual tab).

This ticket was mentioned in Slack in #core by boren. View the logs.


5 years ago

#9 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 31718:

Editor: Hide TinyMCE help button on mobile.

props MattyRob, iseulde.
fixes #31161.

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.