WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#31163 closed defect (bug) (fixed)

Cannot disable the text editor without auto expand breaking

Reported by: iseulde Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.0
Component: Editor Keywords: has-patch
Focuses: javascript Cc:

Description

Test:

add_filter( 'wp_editor_settings', function( $settings, $id ) {
	if ( $id === 'content' ) {
		$settings['quicktags'] = false;
	}

	return $settings;
}, 10, 2 );

We're assuming both editors will be there, but plugins can disable one.
Additionally, the DFW button disappears.

Attachments (1)

31163.patch (831 bytes) - added by iseulde 7 years ago.

Download all attachments as: .zip

Change History (6)

#1 follow-up: @DrewAPicture
7 years ago

  • Keywords reporter-feedback added

I can't confirm that auto-expand breaks –– I tried it before and after and it worked fine both times. I can however confirm that the DFW button disappears. This is latest Firefox if you think that makes a difference.

#2 in reply to: ↑ 1 @SergeyBiryukov
7 years ago

Replying to DrewAPicture:

I can't confirm that auto-expand breaks –– I tried it before and after and it worked fine both times.

Auto-expand seems to work for me as well, but I see a JS error in Debug Bar, in both Firefox and Chrome:

TypeError: $top.parent(...).offset(...) is undefined
http://trunk.wordpress/wp-admin/js/editor-expand.js?ver=4.2-alpha-31308 line 353

@iseulde
7 years ago

#3 @iseulde
7 years ago

  • Keywords has-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 4.2

#4 @azaozz
7 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31361:

Editor: prevent errors in editor-expand when the Text editor is not used. Props iseulde, fixes #31163.

#5 @iseulde
6 years ago

#31716 was marked as a duplicate.

Note: See TracTickets for help on using tickets.